deps: update V8 to 13.3.415.20

[targos]

Notable changes:

• Atomics.pause
• WebAssembly Memory64

@nodejs/v8-update @nodejs/tsc

Supersedes #56842

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/security-wg
• @nodejs/v8-update

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65055/

[targos]

@nodejs/platform-windows There are new compiler errors (including with clang-cl this time):
https://ci.nodejs.org/job/node-compile-windows/60341/
https://ci.nodejs.org/job/node-compile-windows-debug/26107/nodes=win-vs2022/

[targos]

There are some crashes in debug mode: https://ci.nodejs.org/job/node-test-commit-arm-debug/17147/

/cc @joyeecheung, seems related to cppgc

[joyeecheung]

The crash looks similar to #56327 - we probably have been forgetting to put the locker somewhere and it's somehow exposed by recent V8 changes. Looking..

[targos]

Ping @nodejs/platform-windows

[joyeecheung]

I cannot reproduce test-child-process-exec-maxbuf locally though #57031 fixes test-heapsnapshot-near-heap-limit-bounded locally for me. From the stack trace it seems they are caused by something similar so it may fix the other one as well.

[joyeecheung]

Pushed the commit from #57031

[joyeecheung]

I don't have a Windows machine at hand at the hour, but I think this should fix it for the windows-clang build from a look at the error

diff --git a/deps/v8/src/wasm/wasm-module-sourcemap.cc b/deps/v8/src/wasm/wasm-module-sourcemap.cc
index f95107faba..c65389839e 100644
--- a/deps/v8/src/wasm/wasm-module-sourcemap.cc
+++ b/deps/v8/src/wasm/wasm-module-sourcemap.cc
@@ -69,7 +69,7 @@ WasmModuleSourceMap::WasmModuleSourceMap(v8::Isolate* v8_isolate,
     size_t file_name_sz = file_name->Utf8LengthV2(v8_isolate) + 1;
     std::unique_ptr<char[]> file_name_buf(new char[file_name_sz]);
     file_name->WriteUtf8V2(v8_isolate, file_name_buf.get(), file_name_sz,
-                           String::WriteFlags::kNullTerminate);
+                           v8::String::WriteFlags::kNullTerminate);
     filenames.emplace_back(file_name_buf.get());
   }

@@ -84,7 +84,7 @@ WasmModuleSourceMap::WasmModuleSourceMap(v8::Isolate* v8_isolate,
   size_t mappings_sz = mappings->Utf8LengthV2(v8_isolate) + 1;
   std::unique_ptr<char[]> mappings_buf(new char[mappings_sz]);
   mappings->WriteUtf8V2(v8_isolate, mappings_buf.get(), mappings_sz,
-                        String::WriteFlags::kNullTerminate);
+                        v8::String::WriteFlags::kNullTerminate);

   valid_ = DecodeMapping(mappings_buf.get());
 }

The MSVC one looks different though.

[targos]

I don't have a Windows machine at hand at the hour, but I think this should fix it for the windows-clang build from a look at the error

The MSVC one looks different though.

It looks like we could upstream it (other uses of String in that file have the namespace)

[joyeecheung]

Weird enough I cannot reproduce the compilation error with clangcl 19.1.1 on Windows. I suspect the clang version might make a difference? What is the version being run in the CI?

[richardlau]

Weird enough I cannot reproduce the compilation error with clangcl 19.1.1 on Windows. I suspect the clang version might make a difference? What is the version being run in the CI?

18.1.8, according to https://ci.nodejs.org/job/node-compile-windows/60341/nodes=win-vs2022_clang/consoleFull

14:31:14 > set "clang_path=C:\Program Files\Microsoft Visual Studio\2022\Community\VC\\Tools\Llvm\x64\bin\clang.exe" 
14:31:14 
14:31:14 > for /F "tokens=3" %i in ('"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\\Tools\Llvm\x64\bin\clang.exe" --version') do (
14:31:14 set clang_version=%i  
14:31:14  goto clang-found 
14:31:14 ) 
14:31:14 
14:31:14 > (
14:31:14 set clang_version=18.1.8  
14:31:14  goto clang-found 
14:31:14 ) 
14:31:14 
14:31:14 > echo Found Clang version 18.1.8 
14:31:14 Found Clang version 18.1.8
14:31:14 
14:31:14 > set configure_flags= --with-ltcg "--download=all" --with-intl=full-icu --dest-cpu=x64 --verbose --clang-cl=18.1.8

[joyeecheung]

Pushed the namespace fix to see if it fixes the clang-cl error: https://ci.nodejs.org/job/node-compile-windows/60465/nodes=win-vs2022_clang/ ✅

[joyeecheung]

Upstreamed the patch for clangcl to https://chromium-review.googlesource.com/c/v8/v8/+/6271543

[targos]

Test of the debug build: https://ci.nodejs.org/job/node-test-commit-arm-debug/nodes=ubuntu2204_debug-arm64/17272/