Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 13.2.152.37 #56842

Closed
wants to merge 19 commits into from
Closed

deps: update V8 to 13.2.152.37 #56842

wants to merge 19 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Jan 31, 2025

@nodejs/v8-update @nodejs/tsc

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jan 31, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 31, 2025
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. and removed build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 31, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@anonrig

This comment was marked as resolved.

Sign in to view
@targos

This comment was marked as resolved.

Sign in to view
@targos

This comment was marked as outdated.

Sign in to view
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov

This comment was marked as resolved.

Sign in to view
@targos

This comment was marked as outdated.

Sign in to view
@targos targos mentioned this pull request Feb 4, 2025
Open
@guybedford guybedford mentioned this pull request Feb 5, 2025
Open
@targos
Copy link
Member Author

targos commented Feb 5, 2025

I updated the MSVC compat patch to remove the __attribute__(...) in that case: a6afdf4

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@targos
Copy link
Member Author

targos commented Feb 5, 2025

@nodejs/platform-windows @StefanStojanovic There are other errors with MSVC:

https://ci.nodejs.org/job/node-compile-windows/60294/nodes=win-vs2022/console

15:47:14 C:\workspace\node-compile-windows-debug\node\deps\v8\src\runtime\runtime-test.cc(1172,15): error C2672: 'std::min': no matching overloaded function found [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

https://ci.nodejs.org/job/node-compile-windows/60294/nodes=win-vs2022-arm64/console

15:31:33 C:\workspace\node-compile-windows\node\deps\v8\src\codegen\arm64\assembler-arm64.h(171,26): error C2280: 'std::optional<v8::internal::Zone>::optional(const std::optional<v8::internal::Zone> &)': attempting to reference a deleted function [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers_slow_host.vcxproj]
15:31:33 C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\optional(617,1): message : compiler has generated 'std::optional<v8::internal::Zone>::optional' here [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers_slow_host.vcxproj]
15:31:33 C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\include\optional(617,1): message : 'std::optional<v8::internal::Zone>::optional(const std::optional<v8::internal::Zone> &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'std::_Deleted_move_assign<std::_Optional_construct_base<_Ty>,_Ty>::_Deleted_move_assign(const std::_Deleted_move_assign<std::_Optional_construct_base<_Ty>,_Ty> &)' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_initializers_slow_host.vcxproj]

targos added 2 commits February 5, 2025 16:17
@targos
test: update test-linux-perf-logger
b3c3d46 
New V8 version includes more information about regular expressions.
@targos
build: add /bigobj to compile V8 on Windows
cae04fd
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 5, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65008/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95
Copy link
Contributor

aduh95 commented Feb 5, 2025

FWIW #56645 still reproduces on top of this PR @nodejs/platform-windows

@targos
Copy link
Member Author

targos commented Feb 5, 2025

std::min error comes from: https://github.com/targos/node/blob/9d1f6d4ef79fc2fae6f262054916c2cc4a03df7b/deps/v8/src/runtime/runtime-test.cc#L1171-L1174

@targos
Copy link
Member Author

targos commented Feb 5, 2025

std::optional<... error comes from https://github.com/targos/node/blob/9d1f6d4ef79fc2fae6f262054916c2cc4a03df7b/deps/v8/src/runtime/runtime-test.cc#L1171-L1174a

@targos targos mentioned this pull request Feb 8, 2025
Open
@targos
Copy link
Member Author

targos commented Feb 8, 2025

#56959

@targos targos closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @anonrig @aduh95 @StefanStojanovic @kxxt @richardlau