Skip to content

Update m+s#64

Merged
mberacochea merged 14 commits into
devfrom
update-m+s
May 14, 2026
Merged

Update m+s#64
mberacochea merged 14 commits into
devfrom
update-m+s

Conversation

@KateSakharova
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 542f1c1

+| ✅ 249 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗  14 tests had warnings |!
Details

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in README.md: Add bibliography of tools and data used in your pipeline
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • local_component_structure - fasta_validation.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - rna_detection.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
  • local_component_structure - genome_evaluation.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • nextflow_config - Config variable ignored: params.input
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-seqsubmit_logo_dark.png
  • container_configs - container_configs

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-05-14 10:01:53

Base automatically changed from latest-template-merge-attempt to dev May 11, 2026 10:18
Comment thread workflows/assemblysubmit.nf Outdated
Comment thread workflows/assemblysubmit.nf Outdated
Comment thread workflows/assemblysubmit.nf Outdated
Comment thread workflows/assemblysubmit.nf Outdated
Comment thread workflows/genomesubmit.nf Outdated
Comment thread workflows/genomesubmit.nf Outdated
Comment thread main.nf Outdated
Copy link
Copy Markdown
Collaborator

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 @KateSakharova good stuff. I gave it a relatively quick review, I skimmed over what I think are template update stuff

I've added the arm64 config files and profiles, this is not part of the
template yet but it will soon.

With this setup it is possible to run the pipeline on ARM laptops
such as apple sillicon ones.

There are few more profiles, for more info https://nf-co.re/blog/2024/seqera-containers-part-2
@KateSakharova KateSakharova marked this pull request as ready for review May 13, 2026 13:02
@mberacochea mberacochea self-requested a review May 14, 2026 09:18
Copy link
Copy Markdown
Collaborator

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KateSakharova - this one can be merged.

I'm re-doing the snapshots now, so I'll push and merge

@mberacochea mberacochea merged commit f3c1546 into dev May 14, 2026
20 checks passed
@KateSakharova KateSakharova deleted the update-m+s branch May 15, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor FASTA validation

4 participants