Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metaspace submit #8170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Metaspace submit #8170
Changes from all commits
cf20cfa
1f88e61
a727319
f2d59b4
ef14739
afe57fe
78b5084
b36a05e
8de1a00
e793aff
58729a2
4bee093
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Which of these would be the real use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the confusion. I think secrets has to be defined by the user using
nextflow secrets set METASPACE_API_KEY "USER_API_KEY"
. I was trying to mimic the setup from sentieon modules (https://github.com/nf-core/modules/blob/9fe7867a4f012db581d7bd560228ded1074eb0e5/modules/nf-core/sentieon/dedup/tests/nextflow.config).So it can be tested locally without the need to use
nextflow secrets
by just export api key as environment variable. Or it could be set bynextflow secrets
. Both should work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SPPearce Is this more clear ?