-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metaspace submit #8170
base: master
Are you sure you want to change the base?
Metaspace submit #8170
Conversation
I migrated this PR #8087 to this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module has come a long way, and now it's very close to being ready. I have one minor remark, and I still want the other reviewers from the previous take to see this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not want meta maps here?
// NOTE This is how nf-core/metaspace/submit users will use METASPACE submission in real world use | ||
API_KEY = "$METASPACE_API_KEY" | ||
|
||
// NOTE This is how nf-core/metaspace/submit users will test out METASPACE submission with a user API key | ||
// nextflow secrets set METASPACE_API_KEY "USER_API_KEY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? Which of these would be the real use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the confusion. I think secrets has to be defined by the user using nextflow secrets set METASPACE_API_KEY "USER_API_KEY"
. I was trying to mimic the setup from sentieon modules (https://github.com/nf-core/modules/blob/9fe7867a4f012db581d7bd560228ded1074eb0e5/modules/nf-core/sentieon/dedup/tests/nextflow.config).
So it can be tested locally without the need to use nextflow secrets
by just export api key as environment variable. Or it could be set by nextflow secrets
. Both should work.
My PR for a bioconda recipe was recently merged and now we have a bioconda package (https://anaconda.org/bioconda/metaspace2020). So no more linting issues :) |
PR checklist
Closes #7878
Closes #8087
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda