Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metaspace submit #8170

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Metaspace submit #8170

wants to merge 12 commits into from

Conversation

Bisho2122
Copy link
Contributor

@Bisho2122 Bisho2122 commented Mar 31, 2025

PR checklist

Closes #7878
Closes #8087

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@Bisho2122
Copy link
Contributor Author

I migrated this PR #8087 to this one.

Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module has come a long way, and now it's very close to being ready. I have one minor remark, and I still want the other reviewers from the previous take to see this one.

@Bisho2122 Bisho2122 requested a review from a team as a code owner April 1, 2025 11:42
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want meta maps here?

Comment on lines +2 to +6
// NOTE This is how nf-core/metaspace/submit users will use METASPACE submission in real world use
API_KEY = "$METASPACE_API_KEY"

// NOTE This is how nf-core/metaspace/submit users will test out METASPACE submission with a user API key
// nextflow secrets set METASPACE_API_KEY "USER_API_KEY"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? Which of these would be the real use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the confusion. I think secrets has to be defined by the user using nextflow secrets set METASPACE_API_KEY "USER_API_KEY". I was trying to mimic the setup from sentieon modules (https://github.com/nf-core/modules/blob/9fe7867a4f012db581d7bd560228ded1074eb0e5/modules/nf-core/sentieon/dedup/tests/nextflow.config).

So it can be tested locally without the need to use nextflow secrets by just export api key as environment variable. Or it could be set by nextflow secrets. Both should work.

@Bisho2122 Bisho2122 mentioned this pull request Apr 3, 2025
17 tasks
@Bisho2122
Copy link
Contributor Author

My PR for a bioconda recipe was recently merged and now we have a bioconda package (https://anaconda.org/bioconda/metaspace2020). So no more linting issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

METASPACE API submission
3 participants