Skip to content

Fix domain classification compatibility with long reads #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfy133 merged 9 commits into from
Nov 13, 2025
Merged

Fix domain classification compatibility with long reads #929

jfy133 merged 9 commits into from
Nov 13, 2025

Conversation

@prototaxites
Copy link
Contributor

@prototaxites prototaxites commented Nov 13, 2025 •
edited
Loading

Fixes #928

  • Remove the assembler argument from the script
  • Just try and pull out the identifier regardless of assembler

Also, I've changed the nf-test configuration so we trigger a full test run when a script in bin/ is modified. I think this is sensible, but happy to discuss if anyone disagrees.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@prototaxites prototaxites changed the base branch from main to dev November 13, 2025 08:58
@nf-core nf-core deleted a comment from github-actions bot Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d37a552

+| ✅ 379 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.4.1
  • Run at 2025-11-13 12:24:59

@prototaxites
Copy link
Contributor Author

prototaxites commented Nov 13, 2025

@nf-core-bot fix linting

@prototaxites prototaxites mentioned this pull request Nov 13, 2025
Closed
jfy133
jfy133 approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, actually adding 'bin/*' to the nf-test trigger is a very good idea for all pipelines IMO - any chance you can copy the change to the tools repository too?

jfy133
jfy133 reviewed Nov 13, 2025
View reviewed changes
@jfy133 jfy133 merged commit 52063e1 into dev Nov 13, 2025
21 checks passed
@jfy133 jfy133 deleted the 928-fix-domain-classification-long-reads branch November 13, 2025 13:07
@prototaxites
Copy link
Contributor Author

prototaxites commented Nov 13, 2025

I am ahead of you 😉

nf-core/tools#3897

@jfy133
Copy link
Member

jfy133 commented Nov 13, 2025

I am ahead of you 😉

nf-core/tools#3897

Did I mention you are awesome?

@dialvarezs dialvarezs mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfy133 jfy133 jfy133 approved these changes

@d4straub d4straub Awaiting requested review from d4straub d4straub is a code owner

@muabnezor muabnezor Awaiting requested review from muabnezor muabnezor is a code owner

@dialvarezs dialvarezs Awaiting requested review from dialvarezs dialvarezs is a code owner

Assignees

No one assigned

Labels

ready to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prototaxites @jfy133 @nf-core-bot