-
Notifications
You must be signed in to change notification settings - Fork 143
Release: v5.3.0 Rainbow Rattlesnake #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
…es-contain-unequal-number-of-reads
…es-contain-unequal-number-of-reads
…-unequal-number-of-reads' of github.com:nf-core/mag into 890-metaspades-exit-status-21-paired-read-files-contain-unequal-number-of-reads
|
When using conda, Semibin2 seems to be trying to train a new model... Any ideas why, @d4straub? |
Yes that is intentionally. Semibin2 should train a model with not only conda but also singularity & docker. Because pre-trained models are only available for single-bam input and CI test 1 & 3 have multiple bam input. However, I just checked the error report, and the model is trained in just a few seconds. The last message by Semibin2 is Edit:
Edit2: CI test 4 ('-profile hybrid' ) has a single sample, i.e. model is pre-trained, input only one bam file. Still a mystery why SemiBin2 fails with conda on multiple samples in CI tests. |
FriederikeHanssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address #948 review comments
I can reproduce it locally with conda. It's strange, because when it reaches that point of "Start binning.", CPU usage drops to 0% and stays like that. I'm going to check the conda vs the container dependencies if I this is because some bad pin. EDIT: There is an issue that seems to resemble this behaviour: BigDataBiology/SemiBin#208 EDIT 2: I found the issue! Seems to be the igraph package that recently got v1.0.0 |
Update semibin module
metaSPAdes error 250 (OOM) triggers retry rather than finish
Improve handling of GTDB-Tk + Bin QC
Co-authored-by: Diego Alvarez S. <[email protected]>
Support long reads assemblers in assembly input
Addedtest_assembly_inputprofile (by @dialvarezs)--generate_bigmag_fileto execute the bigmag workflow that generates the file to be used as input for BIgMAG (added by @jeffe107)ChangedChannel()withchannel()and fix other LSP warnings (by @dialvarezs)TEMPLATE(by @dialvarezs)Fixedcsvtktoqsv(reported by @jfy133 and @julianu, fix by @dialvarezs)DependenciesDeprecatedcsvtk/concatmodule (by @dialvarezs).