Skip to content

Conversation

@d4straub
Copy link
Collaborator

@d4straub d4straub commented Dec 11, 2025

Trigger nf-test for more files (following nf-core/tools#3897) because most tests were skipped in #929 and I promptly introduced a bug (that is fixed here as well).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub d4straub changed the title fix typo in report template fix report and nf-test trigger Dec 11, 2025
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.4.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@d4straub d4straub marked this pull request as ready for review December 11, 2025 14:40
Copy link
Member

@erikrikarddaniel erikrikarddaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything wrong here, but the tests fail. I suppose it's the GitHub glitch that I see on Slack.

@d4straub
Copy link
Collaborator Author

Thanks, I'll make sure that all tests pass before I merge ;)

@d4straub d4straub merged commit ab5778b into nf-core:dev Dec 12, 2025
88 of 124 checks passed
@d4straub d4straub deleted the fix-report-and-nf-test-trigger branch December 12, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants