Skip to content

Commit

Permalink
Detach vcfanno from the --annotate parameter (#108)
Browse files Browse the repository at this point in the history
* split annotation subwf to make vcfanno runnable without --annotate

* update tests

* prettier

* update changelog

* make sure new tests do run
  • Loading branch information
nvnieuwk authored Feb 11, 2025
1 parent 0376891 commit 64034d4
Show file tree
Hide file tree
Showing 27 changed files with 1,447 additions and 424 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ jobs:
- "bam_variant_calling_qdnaseq"
- "bam_variant_calling_smoove"
- "bam_variant_calling_wisecondorx"
- "vcf_annotate_vep_annotsv_vcfanno"
- "vcf_annotate_vep_annotsv"
- "vcf_annotate_vcfanno"
- "vcf_concat_bcftools"
- "vcf_merge_callers_jasmine"
- "vcf_merge_family_jasmine"
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
5. Fixed language server errors
6. Removed the old output publishing code and used the new workflow output definitions instead
7. Bumped the minimal nextflow version to 24.10.0
8. VCFanno will now run when `--vcfanno_toml` has been given and `--annotate` has not been given. You still need to supply `--annotate` to get the full annotation, but this can be used check for common variants without having to perform full annotation.

### `Fixed`

Expand Down
21 changes: 9 additions & 12 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,12 @@ process {
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
*/

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:BCFTOOLS_FILTER\$" {
withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV:BCFTOOLS_FILTER\$" {
ext.prefix = {"${meta.id}.filter"}
ext.args = "-e 'GT=\"ref\"' --output-type z"
}

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:ANNOTSV_ANNOTSV\$" {
withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV:ANNOTSV_ANNOTSV\$" {
ext.args = {[
"-SVminSize 20",
"-vcf 1",
Expand All @@ -211,12 +211,12 @@ process {
ext.prefix = {"${meta.id}.annot"}
}

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:BCFTOOLS_CONCAT\$" {
withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV:BCFTOOLS_CONCAT\$" {
ext.prefix = "annotsv_annotated"
ext.args = "--output-type z --naive-force"
}

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:ENSEMBLVEP_VEP\$" {
withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV:ENSEMBLVEP_VEP\$" {
ext.prefix = {"${meta.id}.vep"}
ext.args = {[
// specify we use VCF files
Expand All @@ -240,17 +240,14 @@ process {
].join(' ').trim()}
}

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:VCFANNO\$" {
withName: "^.*VCF_ANNOTATE_VCFANNO:VCFANNO\$" {
ext.prefix = {"${meta.id}.${meta.variant_type}.vcfanno"}
ext.args = "-permissive-overlap -ends"
}

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:TABIX_ANNOTATED\$" {
ext.prefix = { "${meta.id}.${meta.variant_type}.annotated" }
}

withName: "^.*VCF_ANNOTATE_VEP_ANNOTSV_VCFANNO:BCFTOOLS_FILTER_COMMON\$" {
ext.prefix = {"${meta.id}.${meta.variant_type}.annotated"}
ext.args = "${params.annotations_filter} --output-type z"
withName: "^.*VCF_ANNOTATE_VCFANNO:BCFTOOLS_FILTER\$" {
ext.prefix = {"${meta.id}.${meta.variant_type}.filtered"}
ext.args = "${params.annotations_filter} --output-type z --write-index=tbi"
}

/*
Expand Down
10 changes: 5 additions & 5 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@
},
"bcftools/filter": {
"branch": "master",
"git_sha": "a3893076a76e91b3ff152faddf872f00778fb224",
"installed_by": ["modules"],
"patch": "modules/nf-core/bcftools/filter/bcftools-filter.diff"
"git_sha": "81880787133db07d9b4c1febd152c090eb8325dc",
"installed_by": ["modules"]
},
"bcftools/sort": {
"branch": "master",
Expand Down Expand Up @@ -152,8 +151,9 @@
},
"vcfanno": {
"branch": "master",
"git_sha": "b558cd24f8751dcda51f957391f5f9cb83e28586",
"installed_by": ["modules"]
"git_sha": "81880787133db07d9b4c1febd152c090eb8325dc",
"installed_by": ["modules"],
"patch": "modules/nf-core/vcfanno/vcfanno.diff"
},
"wisecondorx/convert": {
"branch": "master",
Expand Down
6 changes: 3 additions & 3 deletions modules/nf-core/bcftools/filter/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 13 additions & 7 deletions modules/nf-core/bcftools/filter/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

67 changes: 47 additions & 20 deletions modules/nf-core/bcftools/filter/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 64034d4

Please sign in to comment.