fix: prevent long CLI paths from overflowing status card#2352
fix: prevent long CLI paths from overflowing status card#2352xxiaoxiong wants to merge 1 commit into
Conversation
- Add overflow: hidden, text-overflow: ellipsis, white-space: nowrap to .user-status-card__copy span - Long filesystem paths now truncate with ellipsis instead of breaking card layout - Improves readability of Local CLI startup messages Fixes nexu-io#2206
lefarcen
added
size/XS
Siri-Ray
left a comment
Siri-Ray
left a comment
There was a problem hiding this comment.
Thanks for picking this up, @xxiaoxiong. I found one issue that keeps this from addressing the reported Local CLI startup overflow: the new truncation styles are applied to the design-system user status card, but the linked startup path renders through the assistant waiting/status pill classes instead.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.| line-height: 1.35; | ||
| color: var(--text-muted); | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; |
There was a problem hiding this comment.
This selector does not cover the Local CLI startup path described in #2206. The issue thread identifies the affected chat startup UI as WaitingPill / StatusPill in apps/web/src/components/AssistantMessage.tsx, where the detail text renders as .op-waiting-detail or .status-detail; .user-status-card__copy span is only used by the design-system workspace user status card in ChatPane.tsx. Because the long path never receives these new rules, the reported overflow can still happen. Please move or duplicate the overflow handling onto the actual startup detail selectors, for example by constraining .op-waiting-detail / .status-detail with min-width: 0 plus wrapping or ellipsis rules that fit their flex containers.
|
Heads-up: PR #2283 is also open against #2206 and touches You and @YUHAO-corn may want to coordinate; the maintainer team will decide which path lands. |
|
Looks like you now also have #2531 open for the same #2206 overflow fix, again touching Since this PR already has review feedback and #2531 is a fresh branch for the same issue, it may be worth consolidating into one PR so reviewers are not split across two versions. Happy to keep tracking whichever one you choose to continue. |
|
Fixed! I was targeting the wrong CSS class. The CLI startup path renders through Updated the PR to apply text truncation to the correct class. Long CLI paths will now truncate with ellipsis and stay within the status pill boundary. |
|
Hey @xxiaoxiong, thanks for the quick follow-up. I rechecked the current PR head ( |
|
Rebased on latest main. The fix is correctly targeting The actual change adds text truncation to
This matches the CLI startup path rendering location identified in the review. |
|
Hey @xxiaoxiong, I rechecked against GitHub’s current PR data just now. The PR head is still |
|
@xxiaoxiong friendly reminder: this PR has been waiting on an author response for more than 3 days after reviewer or maintainer feedback. When you have a chance, please reply here or push an update. To keep the queue manageable, PRs with no author activity for more than 5 days after feedback may be closed automatically, but they can be reopened when work resumes. |
3 participants
Summary
Fixes #2206
Prevents long Local CLI startup paths from overflowing the chat status card boundary by adding proper text truncation.
Changes
overflow: hidden,text-overflow: ellipsis, andwhite-space: nowrapto.user-status-card__copy spanBefore
Long paths extended beyond the card boundary, making the UI look broken.
After
Long paths are truncated with ellipsis and stay within the card boundary.
Testing
Type of Change