fix(web): wrap local cli status paths#2283
Conversation
| display: inline-flex; | ||
| align-self: flex-start; | ||
| align-items: center; | ||
| flex-wrap: wrap; |
There was a problem hiding this comment.
Wrapping the detail text here fixes the overflow, but the pill still keeps align-items: center while AssistantMessage renders this as a short label plus a potentially multi-line detail (StatusPill here and WaitingPill at apps/web/src/components/AssistantMessage.tsx:1005-1009). Once a long Local CLI path wraps, the label and waiting dot get vertically centered against the whole block, so the first wrapped line reads visibly misaligned. Consider either top-aligning the wrapped content (align-items: flex-start) or forcing the detail onto its own row with flex-basis: 100% plus a small row-gap; the same adjustment should be applied to the matching .op-waiting block below so both pills stay aligned.
|
Addressed the non-blocking visual follow-up from Looper. What changed:
Validation:
|
nettee
left a comment
There was a problem hiding this comment.
I reviewed the updated wrap fix in apps/web/src/index.css and verified the final CSS now covers both the status-pill and op-waiting overflow cases, including the follow-up top-alignment for wrapped details.
Thanks for tightening up the visual edge case and following through on the alignment polish.
🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.
Fixes #2206
Why
I picked this up from the reported Local CLI startup overflow. Long filesystem paths can appear in the chat startup/status card and should not push past the card boundary.
What users will see
Long Local CLI startup/status details wrap inside the chat status card instead of overflowing horizontally.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope. Include a paragraph on what we get vs. what bytes we ship (seeCONTRIBUTING.md→ Code style)Screenshots
Before: the issue screenshot shows the long Local CLI path extending beyond the chat status card.
After: I verified the changed CSS in headless Chrome with a 260px card and a long unbroken Local CLI path. The measured
.card,.op-waiting,.op-waiting-detail,.status-pill, and.status-detailall hadscrollWidth <= clientWidth, so no horizontal overflow was present.Bug fix verification
mainand green on this branch? no; verified with targeted component tests, static review, and headless Chrome layout measurement instead.Validation
pnpm installpnpm guardpnpm --filter @open-design/web typecheckpnpm --dir apps/web exec vitest run tests/components/AssistantMessage.test.tsxgit diff --checkWaitingPill/StatusPillpath/status detail overflow.