Skip to content

fix(call): polish speaker view #19216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DorraJaouad wants to merge 6 commits into
base: main
Choose a base branch
from
+47 −25
Open

fix(call): polish speaker view #19216

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a38215
fix(call): align one participant stripe to the end.
DorraJaouad Aug 31, 2026
19b4bef
fix(call): paint the tiles of a call on a solid background
DorraJaouad Aug 31, 2026
7f695a8
feat(call): lay the stripe out as a card
DorraJaouad Aug 31, 2026
7f064f6
fix(call): float the stripe while nobody else is in the call
DorraJaouad Aug 31, 2026
7225340
refactor(call): name the promoted video prop after the layout it drives
DorraJaouad Aug 31, 2026
fb58d55
fix(Stripe): adjust positioning of stripe against promoted area
DorraJaouad Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/CallView/Grid/VideosGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,10 @@ export default {
gridTemplateColumns: `repeat(${getHalfColumnCount(columns)}, ${halfColumnWidth})`,
gridTemplateRows: `repeat(${rows}, minmax(${this.dpiAwareMinHeight}px, 1fr))`,
// The columns no longer take the whole width once they are
// capped, so the grid itself has to center them
justifyContent: 'center',
// capped, so the grid itself has to place them. A stripe holding
// a single tile keeps it at the inline end, where the tiles of a
// fuller stripe end as well, rather than in the middle.
justifyContent: this.isStripe && this.totalTiles === 1 ? 'end' : 'center',

@Antreesy Antreesy Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a guard for noLocalVideoReserve - so if it's three people, but your video will be hidden, don't shift a sole person in stripe to your place

@DorraJaouad DorraJaouad Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then, one video will be centered in the middle which is an issue at the moment

@Antreesy Antreesy Sep 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put it to 'start', if it's not you?

}
},

Expand Down