fix(call): polish speaker view - #19216
Open
DorraJaouad wants to merge 6 commits into
Open
Conversation
DorraJaouad
added
feature: frontend 🖌️
DorraJaouad
changed the title
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
The background of a tile was a translucent tint, so whatever the tile sat over - the promoted video, in a stripe - showed through it in full detail. Paint the shade that tint used to composite to instead, and drop the `background-image` reset left over with it: no rule sets an image here. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
The stripe took no surface of its own, so its tiles floated over the call background whether or not there was anything behind them. Give it a card with its leading corners rounded, which reads as being pulled up and pushed back down as the stripe expands and collapses. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
The promoted video covers the whole call view, the stripe floating over it, while a single participant fills the promoted area. A call nobody else has joined yet was left out, so the stripe sat on a card of its own for as long as it was the only thing on screen and dropped it the moment somebody joined. Lay an empty promoted area out the same way. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
`isOneToOne` counted the participants of the call to inset the promoted video by the padding of the wrapper, which is what the full page layout asks for. It names the call rather than the layout, and the two have since parted ways: a call nobody else has joined is laid out full page and is not one to one. Pass the layout itself. SpeakersGrid handed the flag to tiles that are never big, where the class it sets matches no rule, so it is dropped there. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Dorra Jaouad <dorra.jaoued7@gmail.com>
DorraJaouad
force-pushed
the
feat/noid/call-view-stripe-card
branch
from
August 31, 2026 12:19
bb19f47 to
fb58d55
Compare
Antreesy
reviewed
Aug 31, 2026
Antreesy
left a comment
Antreesy
left a comment
Contributor
There was a problem hiding this comment.
Tested, looks better. My only concern is new background color
| // capped, so the grid itself has to place them. A stripe holding | ||
| // a single tile keeps it at the inline end, where the tiles of a | ||
| // fuller stripe end as well, rather than in the middle. | ||
| justifyContent: this.isStripe && this.totalTiles === 1 ? 'end' : 'center', |
Contributor
There was a problem hiding this comment.
This probably needs a guard for noLocalVideoReserve - so if it's three people, but your video will be hidden, don't shift a sole person in stripe to your place
| // left in a one to one call - are lifted off the call by a shadow instead | ||
| .overlap & :deep(.localVideoContainer), | ||
| .overlap & :deep(.video-container-grid) { | ||
| box-shadow: 0 4px 16px rgba(0, 0, 0, 0.5); |
Contributor
There was a problem hiding this comment.
Shadow is cropped at bottom, as it's larger than allowed area:
| // The card the tiles sit on. It is pulled up out of the bottom of the call | ||
| // view and pushed back down when it collapses, so only the corners it leads | ||
| // with are rounded | ||
| .grid-main-wrapper:not(.overlap) & { |
Contributor
There was a problem hiding this comment.
Bottom area feels weird/abrupt, as above and below stripe it's transparent:
Maybe there should be a divider, so a cut-off of video tiles from controls looks intended?
Even rounding up bottom corners feels better to me:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist