Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📆 feat(meetings): Allow moderators to schedule a meeting #14074

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

📆 feat(meetings): Allow moderators to schedule a meeting #14074

wants to merge 2 commits into from
+776 −2

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 7, 2025 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after
2025-01-07_17h42_49 image

🚧 Tasks

  • Add API handling
  • Participants hint (all are invited)
  • Participants selector
  • Split into Popover and Dialog

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Jan 7, 2025
@Antreesy Antreesy self-assigned this Jan 7, 2025
nimishavijay
nimishavijay reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Looks very cool!
Some questions from my end:

  • is it not possible to set the end time too? Seems a bit odd that we can set only the start time, and it's also not so clear how long the event is
  • will this be shown when you click on the top right "Next event" button in Talk? It would be nice to show the upcoming events in a popover along with a "schedule event" button, and show the schedule event section as a separate modal when you click on the button.

@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch 2 times, most recently from ae94cd2 to 9d605f4 Compare January 8, 2025 08:55
@nickvergessen
Copy link
Member

is it not possible to set the end time too? Seems a bit odd that we can set only the start time, and it's also not so clear how long the event is

Fine by me to add a second date-time picker

@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from 9d605f4 to 049c08e Compare January 8, 2025 10:50
@Antreesy Antreesy mentioned this pull request Jan 8, 2025
Merged
13 tasks
Base automatically changed from feat/6292/frontend-schedule-meeting to main January 8, 2025 10:54
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 8, 2025

will this be shown when you click on the top right "Next event" button in Talk? It would be nice to show the upcoming events in a popover along with a "schedule event" button, and show the schedule event section as a separate modal when you click on the button.

Yes, upon the click. Wasn't it decided here to return back to 'previous design' (dialog instead of popover)? #14008 (comment)

@nimishavijay
Copy link
Member

@Antreesy your original list item design, but in a popover :)

@nickvergessen
Copy link
Member

Maybe we do a quick call to align on it? I'm also quite confused at the moment :D

@Antreesy Antreesy changed the title feat(meetings): Allow moderators to schedule a meeting 📆 feat(meetings): Allow moderators to schedule a meeting Jan 8, 2025
nickvergessen and others added 2 commits January 8, 2025 13:50
@nickvergessen @Antreesy
feat(meetings): Allow moderators to schedule a meeting
da9767d 
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
[wip]
1e1bc75 
[skip ci]

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting-post branch from cc5d62c to 1e1bc75 Compare January 8, 2025 12:51
nickvergessen
nickvergessen reviewed Jan 8, 2025
View reviewed changes
src/components/CalendarEventsDialog.vue
v-model="selectedDateTimeStart"
:label="t('spreed', 'Meeting start time')"
type="datetime-local" />
<NcDateTimePickerNative id="schedule_meeting_input"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an option to enforce that end is > start
We should use it

nickvergessen
nickvergessen reviewed Jan 8, 2025
View reviewed changes
src/components/CalendarEventsDialog.vue
</template>
</NcSelect>
<div class="calendar-meeting__flex-wrapper">
<NcDateTimePickerNative id="schedule_meeting_input"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an option to enforce that start is > now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay left review comments

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
2. developing enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @nimishavijay