-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meetings): Preview upcoming events #14008
base: main
Are you sure you want to change the base?
Conversation
4cb9bc6
to
0c60eb1
Compare
2986b59
to
4318ec8
Compare
cc @nimishavijay for initial design feedback |
Nice! Looks great already! :) Some points for feedback (sorted by priority from a design perspective, so first item is highest prio, last one is low prio)
Altogether ideally it could look like this, but the 3 points can be worked on separately as well :) Great work so far! :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
4318ec8
to
92dfb73
Compare
Ah I see, no worries, the screenshot you posted seems great. We should just reduce the width and the "Schedule meeting" button at the bottom of the empty content :)
Checked with the rest of the design team and the verdict was that your original design looks way better visually 😅 So we could go ahead with that instead of the list view in calendar, with only the wording change to use the same wording as it is shown in the "Next call" button. So instead of
It can be
Sorry for the confusion! |
92dfb73
to
0357abe
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
…rs and default calendar Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
0357abe
to
fd069f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works well, UI is also good.
Just a remark related to the upcoming events endpoint, it doesn't show correctly the daily recurrent events (probably because they lead to duplicated objects in the response).
Signed-off-by: Maksim Sukharev <[email protected]>
…calendars and default calendar Signed-off-by: Maksim Sukharev <[email protected]>
b9a863e
to
ae94cd2
Compare
[skip ci] Signed-off-by: Maksim Sukharev <[email protected]>
ae94cd2
to
9d605f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👍🏻 ✅
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist