Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meetings): Preview upcoming events #14008

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Dec 16, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Light Dark
image image
image image
image image

2024-12-17_17h24_33

🚧 Tasks

  • Get calendars info and map to Select option
  • Preview upcoming events (in fancy way)
  • 401 - public conversations
  • Add "shedule meeting" form to submit
Trigger Form
2024-12-16_19h34_42 image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Dec 16, 2024
@Antreesy Antreesy self-assigned this Dec 16, 2024
@Antreesy Antreesy force-pushed the fix/noid/groupware-store branch from 4cb9bc6 to 0c60eb1 Compare December 17, 2024 12:10
Base automatically changed from fix/noid/groupware-store to main December 17, 2024 12:14
@Antreesy Antreesy changed the title feat(meetings): Preview upcoming events and schedule a meeting feat(meetings): Preview upcoming events Dec 17, 2024
@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from 2986b59 to 4318ec8 Compare December 17, 2024 16:39
@Antreesy
Copy link
Contributor Author

cc @nimishavijay for initial design feedback

@nimishavijay
Copy link
Member

nimishavijay commented Dec 18, 2024

Nice! Looks great already! :) Some points for feedback (sorted by priority from a design perspective, so first item is highest prio, last one is low prio)

  • Can we show the "Schedule a new meeting" inside the modal/popover as the last item with secondary styling and a plus icon to avoid putting more and more things in the 3 dot menu?

  • Would it also be possible to move this whole thing into a popover that appears below the "Next call" button? Then we can remove the "Upcoming events" heading too?

  • Would it be possible to replicate the UI of the calendar list view? That way it's not a deviation from the existing design already

Altogether ideally it could look like this, but the 3 points can be worked on separately as well :)

image

Great work so far! :)

@Antreesy

This comment was marked as off-topic.

@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from 4318ec8 to 92dfb73 Compare December 18, 2024 18:43
@nimishavijay
Copy link
Member

Doable, but atm we do not show 'Next call' popup if there are no events assigned to this conversation (also hidden on mobile screensize). Shall we show it as always-on?

Ah I see, no worries, the screenshot you posted seems great. We should just reduce the width and the "Schedule meeting" button at the bottom of the empty content :)

We're missing some attributes from API (like endtime of meeting, or whether it's an "All day" event. But I think, reccurence indicator and start time would be enough for now?

Checked with the rest of the design team and the verdict was that your original design looks way better visually 😅 So we could go ahead with that instead of the list view in calendar, with only the wording change to use the same wording as it is shown in the "Next call" button. So instead of

Talk team call
17 December 2024 19:00 

It can be

Talk team call
Tuesday 19:00

Sorry for the confusion!

@Antreesy Antreesy requested a review from DorraJaouad January 7, 2025 11:46
src/components/TopBar/TopBar.vue Outdated Show resolved Hide resolved
src/components/CalendarEventsDialog.vue Outdated Show resolved Hide resolved
src/components/CalendarEventsDialog.vue Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from 92dfb73 to 0357abe Compare January 7, 2025 14:56
@Antreesy Antreesy marked this pull request as ready for review January 7, 2025 15:02
@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from 0357abe to fd069f0 Compare January 7, 2025 15:34
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works well, UI is also good.
Just a remark related to the upcoming events endpoint, it doesn't show correctly the daily recurrent events (probably because they lead to duplicated objects in the response).

src/types/vendor/@nextcloud/cdav-library.d.ts Outdated Show resolved Hide resolved
src/services/CalDavClient.ts Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.vue Show resolved Hide resolved
src/components/CalendarEventsDialog.vue Outdated Show resolved Hide resolved
src/components/CalendarEventsDialog.vue Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.vue Show resolved Hide resolved
src/stores/groupware.ts Show resolved Hide resolved
@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from b9a863e to ae94cd2 Compare January 8, 2025 08:28
@Antreesy Antreesy force-pushed the feat/6292/frontend-schedule-meeting branch from ae94cd2 to 9d605f4 Compare January 8, 2025 08:55
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍🏻 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants