Skip to content

fix(ldap): Avoid calling ldap_filter with an empty filter #64027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarlSchwan wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

fix(ldap): Avoid calling ldap_filter with an empty filter #64027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/user_ldap/lib/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,12 @@ private function doSoftValidation(): void {
}
}

// an empty filter is invalid and causes ldap_search() to fail, so
// fall back to matching any object
if (empty($this->configuration->ldapUserFilter)) {

@blizzz blizzz Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it?

I remember empty() does not work against virtual attributes from magic getters. See https://www.php.net/manual/en/function.empty.php#refsect1-function.empty-notes

Either fetch the value first, or implement __isset() in Configuration.

$this->configuration->ldapUserFilter = '(objectClass=*)';
}

foreach (['ldapExpertUUIDUserAttr' => 'ldapUuidUserAttribute',
'ldapExpertUUIDGroupAttr' => 'ldapUuidGroupAttribute'] as $expertSetting => $effectiveSetting) {
$uuidOverride = $this->configuration->$expertSetting;
Expand Down
Loading