fix(ldap): Avoid calling ldap_filter with an empty filter - #64027
Open
CarlSchwan wants to merge 1 commit into
Open
fix(ldap): Avoid calling ldap_filter with an empty filter#64027CarlSchwan wants to merge 1 commit into
CarlSchwan wants to merge 1 commit into
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
Altahrim,
come-nc,
provokateurin and
sorbaugh
and removed request for
a team
September 4, 2026 15:19
blizzz
requested changes
Sep 4, 2026
|
|
||
| // an empty filter is invalid and causes ldap_search() to fail, so | ||
| // fall back to matching any object | ||
| if (empty($this->configuration->ldapUserFilter)) { |
Member
There was a problem hiding this comment.
Did you try it?
I remember empty() does not work against virtual attributes from magic getters. See https://www.php.net/manual/en/function.empty.php#refsect1-function.empty-notes
Either fetch the value first, or implement __isset() in Configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)