Skip to content

[Workflow engine] Add warning when context_chat and files_accesscontrol are enabled #53260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julien-nc wants to merge 2 commits into from
Closed

[Workflow engine] Add warning when context_chat and files_accesscontrol are enabled #53260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75aa2fb
feat(workflowengine): add warning when context_chat and files_accessc…
julien-nc Jun 2, 2025
20f9109
chore(assets): Recompile assets
julien-nc Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/workflowengine/lib/Settings/ASettings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use OCA\WorkflowEngine\AppInfo\Application;
use OCA\WorkflowEngine\Manager;
use OCP\App\IAppManager;
use OCP\AppFramework\Http\TemplateResponse;
use OCP\AppFramework\Services\IInitialState;
use OCP\EventDispatcher\IEventDispatcher;
Expand All @@ -34,6 +35,7 @@ public function __construct(
private IInitialState $initialStateService,
private IConfig $config,
private IURLGenerator $urlGenerator,
private IAppManager $appManager,
) {
}

Expand Down Expand Up @@ -83,6 +85,11 @@ public function getForm(): TemplateResponse {
$this->urlGenerator->linkToDocs('admin-workflowengine')
);

$this->initialStateService->provideInitialState(
'context-chat-files_acesscontrol',
$this->appManager->isEnabledForAnyone('context_chat') && $this->appManager->isEnabledForAnyone('files_accesscontrol')
);

return new TemplateResponse(Application::APP_ID, 'settings', [], 'blank');
}

Expand Down
7 changes: 7 additions & 0 deletions apps/workflowengine/src/components/Workflow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
-->
<template>
<div id="workflowengine">
<NcNoteCard v-if="contextChatPlusFilesAccessControl"
type="warning">
{{ t('workflowengine', 'The "Context chat" and "File access control" apps are enabled. Keep in mind that Context Chat is not affected by the File access control rules and will index files which access is denied by a rule.') }}

@susnux susnux Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Context chat" or "Context Chat"? Should only have one spelling.

</NcNoteCard>
<NcSettingsSection :name="t('workflowengine', 'Available flows')"
:doc-url="workflowDocUrl">
<p v-if="isAdminScope" class="settings-hint">
Expand Down Expand Up @@ -69,6 +73,7 @@ import NcButton from '@nextcloud/vue/components/NcButton'
import NcEmptyContent from '@nextcloud/vue/components/NcEmptyContent'
import NcIconSvgWrapper from '@nextcloud/vue/components/NcIconSvgWrapper'
import NcSettingsSection from '@nextcloud/vue/components/NcSettingsSection'
import NcNoteCard from '@nextcloud/vue/components/NcNoteCard'
import { mapGetters, mapState } from 'vuex'
import { generateUrl } from '@nextcloud/router'
import { loadState } from '@nextcloud/initial-state'
Expand All @@ -89,6 +94,7 @@ export default {
NcEmptyContent,
NcIconSvgWrapper,
NcSettingsSection,
NcNoteCard,
Operation,
Rule,
},
Expand All @@ -97,6 +103,7 @@ export default {
showMoreOperations: false,
appstoreUrl: generateUrl('settings/apps/workflow'),
workflowDocUrl: loadState('workflowengine', 'doc-url'),
contextChatPlusFilesAccessControl: loadState('workflowengine', 'context-chat-files_acesscontrol'),
WorkflowOffSvg,
}
},
Expand Down
4 changes: 2 additions & 2 deletions dist/workflowengine-workflowengine.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/workflowengine-workflowengine.js.map
View file
Open in desktop

Large diffs are not rendered by default.