Conversation
…ontrol are enabled Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/workflow-contextchat-filesaccesscontrol-warning
branch
from
June 2, 2025 12:19
6fefcad to
20f9109
Compare
susnux
reviewed
Jun 2, 2025
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
Not really sure its a good thing to add custom 3rdparty logic into another apps code, probably it would be cleaner to have this in the context chat as thats the app overriding the permissions check. But not sure how feasible that is.
| <div id="workflowengine"> | ||
| <NcNoteCard v-if="contextChatPlusFilesAccessControl" | ||
| type="warning"> | ||
| {{ t('workflowengine', 'The "Context chat" and "File access control" apps are enabled. Keep in mind that Context Chat is not affected by the File access control rules and will index files which access is denied by a rule.') }} |
Contributor
There was a problem hiding this comment.
"Context chat" or "Context Chat"? Should only have one spelling.
Member
Author
|
Let's drop this for now, it is enough to mention that in the documentation, see nextcloud/documentation#13176 |
susnux
deleted the
enh/noid/workflow-contextchat-filesaccesscontrol-warning
branch
November 1, 2025 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To mention that Context chat will index files without respecting access control rules.