Add export/import functionality for forms - #3380
timedin-de wants to merge 2 commits into
Conversation
88628b8 to
87bfc7c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@timedin-de Please don't merge the main branch into your branch, always rebase your's on main. Also please sign-off your commits. |
5a575cf to
c5fb19b
Compare
|
@Chartman123 i dont think i did merge the main branch into mine, did sth slip through? Yes, will do, sorry for forgetting it everytime ^^ |
9c27a97 to
958c585
Compare
|
Now the history looks clean, don't now what it was then... |
b24065c to
992e49d
Compare
992e49d to
87a5043
Compare
Chartman123
left a comment
There was a problem hiding this comment.
I've had a quick look at the PR and added a few comments :)
|
@Chartman123 i added the fixup commits for your comments, i'll rebase them if you accept them One other thing I would improve is validation/sanitasation of import/export. I'd make whitelist for allowed properties and remove others (or fail the request?) and copy the validations for questions: areExtraSettingsValid and |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@timedin-de are you still working on this? |
yes, im currently less active. Do you have any additions missing in this? And a decision for sanitazation? |
I vote for the whitelist and throw an error if other properties are part of the request.
No, don't think so :) |
a6159d1 to
1958037
Compare
9727e29 to
6a8b845
Compare
|
@timedin-de Did you merge main again? Please always use rebase... And can you please remove the issue id from the commit message? It creates a new log record on every push in the issue. |
6a8b845 to
06a1c8a
Compare
I'm sorry, i dont know what, but something got messed up while rebasing (promise, i didnt merge 😬 ) Now it should be clean. Edit: it seems it messed up while doing the interactive rebase, I'll need to recheck the git docs on that. |
06a1c8a to
f17f825
Compare
|
I think you need to make sure that your forked main is up-to-date before doing the rebase :) |
f17f825 to
a3e728d
Compare
thanks, yeah that and i ran Now it should be clean |
a3e728d to
765351d
Compare
|
@timedin-de im going over the pr currently, few points first before getting into the review:
|
da2f589 to
ecfa50b
Compare
f19f1e2 to
70ccce5
Compare
|
Added your changes, rebased and pushed clean |
We've changed the way min/max dates are stored in the db now. Old values can still be stored as unix timestamp/integer. Newer values will be stored as date string 'yyyy-mm-dd' |
I see, i had an old frontend cache, now i tested with string dates but it worked for me. Can you confirm its still there? As the import function is using the same formsService->areExtraSettingsValid from normal form creation it should always be in sync with (date) format changes |
Signed-off-by: TimedIn <git@timedin.net>
Signed-off-by: TimedIn <git@timedin.net>
70ccce5 to
369d032
Compare

building export and import via json
Download Button:
#1425