fixup! feat: downloading forms

rename download to export

Author: timedin-de

lib/Controller/ApiController.php

@@ -369,7 +369,7 @@ private function setDefaults(array $formData) {
 	 * Read all information to edit a Form (form, questions, options, except submissions/answers)
 	 *
 	 * @param int $formId Id of the form
-	 * @param ?bool $download if the form should be downloaded
+	 * @param ?bool $export if the form should be downloaded
 	 * @return DataResponse<Http::STATUS_OK, FormsForm, array{}>|DataDownloadResponse<Http::STATUS_OK, 'application/json', array{}>
 	 * @throws OCSBadRequestException Could not find form
 	 * @throws OCSForbiddenException User has no permissions to get this form
@@ -380,10 +380,10 @@ private function setDefaults(array $formData) {
 	#[NoAdminRequired()]
 	#[BruteForceProtection(action: 'form')]
 	#[ApiRoute(verb: 'GET', url: '/api/v3/forms/{formId}')]
-	public function getForm(int $formId, ?bool $download): DataResponse|DataDownloadResponse {
+	public function getForm(int $formId, ?bool $export): DataResponse|DataDownloadResponse {
 		$form = $this->formsService->getFormIfAllowed($formId, Constants::PERMISSION_SUBMIT);
 
-		if ($download) {
+		if ($export) {
 			$formData = $this->formsService->getPublicForm($form);
 			unset($formData['hash']);
 			unset($formData['created']);
@@ -407,11 +407,11 @@ public function getForm(int $formId, ?bool $download): DataResponse|DataDownload
 				}
 			}
 
-			$downloadFile = ['form' => $formData,'appVersion' => $this->appManager->getAppVersion('forms')];
+			$exportFile = ['form' => $formData,'appVersion' => $this->appManager->getAppVersion('forms')];
 			$fileName = $this->filePathHelper->normalizeFileName($form->getTitle() . '.json');
 
 			return new DataDownloadResponse(
-				json_encode($downloadFile), $fileName, 'application/json');
+				json_encode($exportFile), $fileName, 'application/json');
 		}
 
 		return new DataResponse($this->formsService->getForm($form));

openapi.json

@@ -1049,7 +1049,7 @@
                         }
                     },
                     {
-                        "name": "download",
+                        "name": "export",
                         "in": "query",
                         "description": "if the form should be downloaded",
                         "schema": {

src/Forms.vue

@@ -603,8 +603,8 @@ export default {
 			showVersionMismatch.value = false
 			formForImport = undefined
 		}
-		const onDownloadForm = async (id) => {
-			const url = generateOcsUrl('apps/forms/api/v3/forms/{id}?download=1', {
+		const onExportForm = async (id) => {
+			const url = generateOcsUrl('apps/forms/api/v3/forms/{id}?export=1', {
 				id,
 			})
 			window.open(url, '_blank')
@@ -696,7 +696,7 @@ export default {
 			fetchPartialForm,
 			onNewForm,
 			onCloneForm,
-			onDownloadForm,
+			onExportForm,
 			onUploadForm,
 			onDeleteForm,
 			onImportForm,

src/components/AppNavigationForm.vue

@@ -64,7 +64,7 @@
 				</template>
 				{{ t('forms', 'Copy form') }}
 			</NcActionButton>
-			<NcActionButton v-if="canEdit" closeAfterClick @click="onDownloadForm">
+			<NcActionButton v-if="canEdit" closeAfterClick @click="onExportForm">
 				<template #icon>
 					<NcIconSvgWrapper :svg="IconDownload" />
 				</template>
@@ -302,7 +302,7 @@ export default {
 			this.$emit('clone', this.form.id)
 		},
 
-		onDownloadForm() {
+		onExportForm() {
 			const downloadUrl =
 				generateOcsUrl('apps/forms/api/v3/forms/{id}', {
 					id: this.form.id,