Skip to content

fix: generate rev depending on card version - #4634

Merged
hamza221 merged 1 commit into
mainfrom
fix/rev
Aug 22, 2025
Merged

fix: generate rev depending on card version#4634
hamza221 merged 1 commit into
mainfrom
fix/rev

Conversation

@hamza221

Copy link
Copy Markdown
Contributor

@hamza221 hamza221 self-assigned this Aug 21, 2025
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Aug 21, 2025
@codecov

codecov Bot commented Aug 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 9.69%. Comparing base (ad363d5) to head (422ad78).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/services/checks/invalidREV.js 0.00% 5 Missing and 2 partials ⚠️
src/store/contacts.js 0.00% 3 Missing and 1 partial ⚠️
src/models/contact.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #4634      +/-   ##
==========================================
- Coverage     9.86%   9.69%   -0.18%     
  Complexity     265     265              
==========================================
  Files          124     126       +2     
  Lines         6173    6324     +151     
  Branches      1423    1181     -242     
==========================================
+ Hits           609     613       +4     
- Misses        5441    5590     +149     
+ Partials       123     121       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SebastianKrupinski
SebastianKrupinski dismissed their stale review August 21, 2025 17:51

Jumped the gun

if (version === '4.0') {
contact.vCard.addPropertyWithValue('rev', ICAL.Time.fromJSDate(new Date(), true))
}
if (version === '3.0') {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should alter the condition here. I think this needs to also accommodate, prior versions, as this logic would break down if someone has a card with a lower version. Idk, if it's worth it tho, bring it up tomorrow, lets see what the team thinks

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other versions are supported but let's leave it for the call

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221
hamza221 marked this pull request as ready for review August 22, 2025 14:58
@hamza221
hamza221 requested a review from GVodyanov as a code owner August 22, 2025 14:58

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@hamza221

Copy link
Copy Markdown
Contributor Author

/backport to stable7.2

@hamza221
hamza221 merged commit 57dfc87 into main Aug 22, 2025
35 of 36 checks passed
@hamza221
hamza221 deleted the fix/rev branch August 22, 2025 15:00
@hamza221

Copy link
Copy Markdown
Contributor Author

/backport to stable7.3

@realDayaa

Copy link
Copy Markdown

I think there still is an issue with this merge request unfortunatly.
When changing a contact the rev is now displayed but the timezone is ignored. So when changing a value instead of displaying "now" it shows "in 2 hours".
I have set the timezone of the server and client to Europe/Berlin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants