Skip to content

fix: enforce correct icaltype when constructing VCardTime - #4616

Closed
st3iny wants to merge 2 commits into
mainfrom
fix/rev-constructor-icaltype
Closed

fix: enforce correct icaltype when constructing VCardTime#4616
st3iny wants to merge 2 commits into
mainfrom
fix/rev-constructor-icaltype

Conversation

@st3iny

@st3iny st3iny commented Aug 14, 2025

Copy link
Copy Markdown
Member

Extracted from #4298

On my testing instance I don't see the "repaired invalid rev" error any longer.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny self-assigned this Aug 14, 2025
@st3iny
st3iny requested a review from hamza221 as a code owner August 14, 2025 13:04
@st3iny st3iny added the 3. to review Waiting for reviews label Aug 14, 2025
@st3iny
st3iny requested a review from GVodyanov as a code owner August 14, 2025 13:04
@codecov

codecov Bot commented Aug 14, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.56%. Comparing base (38aef0c) to head (7244014).
⚠️ Report is 287 commits behind head on main.

Files with missing lines Patch % Lines
src/services/checks/invalidREV.js 0.00% 1 Missing ⚠️
src/store/contacts.js 0.00% 1 Missing ⚠️
src/views/Contacts.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4616   +/-   ##
=========================================
  Coverage     10.56%   10.56%           
  Complexity      265      265           
=========================================
  Files           123      123           
  Lines          5767     5767           
  Branches       1262     1262           
=========================================
  Hits            609      609           
  Misses         5035     5035           
  Partials        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

@GVodyanov GVodyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the error by creating or updating a contact and I can't understand why, even after having run a clean install of dependencies.

Does this maybe only work if server is updated? Mine hasn't been updated for a while, is that a requirement for this to work?

@hamza221

Copy link
Copy Markdown
Contributor

Fixed in #4634

@hamza221 hamza221 closed this Aug 22, 2025
@st3iny
st3iny deleted the fix/rev-constructor-icaltype branch August 22, 2025 15:03
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants