fix(resources): tidy up the room filter row - #8790
Merged
SebastianKrupinski merged 2 commits intoAug 28, 2026
Merged
Conversation
Rikdekker
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
August 28, 2026 09:17
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SebastianKrupinski
force-pushed
the
fix/room-picker-select-height
branch
from
August 28, 2026 12:22
afd653e to
cf31e31
Compare
SebastianKrupinski
approved these changes
Aug 28, 2026
SebastianKrupinski
enabled auto-merge
August 28, 2026 12:22
Contributor
|
/backport to stable6.6 |
… to it The Features select renders 2px taller than the Minimum capacity text field beside it, so the two controls in the filter row do not line up. NcSelect sets `padding: var(--border-width-input)` on `.vs__dropdown-toggle`. That padding stacks on top of the `min-height: var(--default-clickable-area)` the toggle already carries, so the select ends up at 36px where the text field sits at 34px. `min-height` is a floor, not a ceiling, and cannot hold the padding back. Measured on Nextcloud 34 with calendar 6.6.0-rc.1: | control | before | after | |--------------------------------|--------|-------| | NcTextField (Minimum capacity) | 34px | 34px | | NcSelect (Features) | 36px | 34px | NcSelect already drops the padding to 0 in its open state, so clearing it here does not make the control jump when the dropdown opens — verified by measuring the closed and open states side by side, both 34px. Signed-off-by: Rik Dekker <rik@rikdekker.nl>
Signed-off-by: Rik Dekker <rik@rikdekker.nl>
SebastianKrupinski
force-pushed
the
fix/room-picker-select-height
branch
from
August 28, 2026 12:23
cf31e31 to
ce5a616
Compare
Contributor
|
Re-base on to main and removed some of the extra comments |
SebastianKrupinski
disabled auto-merge
August 28, 2026 12:40
SebastianKrupinski
added a commit
that referenced
this pull request
Aug 28, 2026
fix(resources): tidy up the room filter row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to the filter row in the room picker, found while testing 6.6.0-rc.1 on Nextcloud 34.
1. The Features select is 2px taller than the text field next to it
NcSelectsets padding on the toggle:That stacks on top of the
min-height: var(--default-clickable-area)the toggle already carries in this component, so the select ends up at 36px where Minimum capacity sits at 34px.min-heightis a floor, not a ceiling, so it cannot hold the padding back.NcTextField(Minimum capacity)NcSelect(Features)Why clearing the padding is safe:
NcSelectalready drops it to0in its open state (.vs--open .vs__dropdown-toggle), where it swaps in the thicker--border-width-input-focusedborder instead. So the control does not jump when the dropdown opens — I measured the closed and open states side by side, both 34px.On fixing this in nextcloud-vue instead: the root cause is in
NcSelect, and every app placing a select next to a text field has the same mismatch. That felt out of scope here, so this fixes it locally. Worth noting the override is forward-compatible: ifNcSelectlater drops the padding itself,padding: 0here becomes redundant rather than harmful — I verified all four combinations (current/fixed component × with/without this override) and every one that includes either fix lands on 34px. Happy to move it intonextcloud-vueif you would rather fix it at the source.2. The filter labels are smaller than the colour is calibrated for
The labels pair
--color-text-maxcontrastwith0.9 * --default-font-size, rendering at 13.5px.--color-text-maxcontrastresolves to#6b6b6b, giving 5.33:1 on--color-main-background. That clears WCAG AA (4.5:1) but not AAA (7:1), and the token is calibrated for text at the default size. Shrinking the label keeps a colour already close to the floor while making the text smaller than what it was picked for — at 13.5px it is well under the 24px large-text threshold, so the full 4.5:1 requirement still applies.Dropping the
font-sizeoverride puts the labels back at 15px. The colour is unchanged, so they stay visually secondary to the controls below them.Both changes are CSS-only, in the same filter row, and verified on a live Nextcloud 34 instance running 6.6.0-rc.1.