[stable6.6] fix(resources): tidy up the room filter row - #8795
Conversation
… to it The Features select renders 2px taller than the Minimum capacity text field beside it, so the two controls in the filter row do not line up. NcSelect sets `padding: var(--border-width-input)` on `.vs__dropdown-toggle`. That padding stacks on top of the `min-height: var(--default-clickable-area)` the toggle already carries, so the select ends up at 36px where the text field sits at 34px. `min-height` is a floor, not a ceiling, and cannot hold the padding back. Measured on Nextcloud 34 with calendar 6.6.0-rc.1: | control | before | after | |--------------------------------|--------|-------| | NcTextField (Minimum capacity) | 34px | 34px | | NcSelect (Features) | 36px | 34px | NcSelect already drops the padding to 0 in its open state, so clearing it here does not make the control jump when the dropdown opens — verified by measuring the closed and open states side by side, both 34px. Signed-off-by: Rik Dekker <rik@rikdekker.nl>
Signed-off-by: Rik Dekker <rik@rikdekker.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The failing DCO check is an email mismatch, not a missing sign-off. Both commits carry Every other check on this backport passes. Happy to re-sign the commits with the matching address if that is easier for you, but since this is a backportbot branch in this repo I did not want to force-push to it myself — just let me know which you prefer. |
All goog, I bypassed it. Just sign the next one properly please |
2 participants
Backport of PR #8790