BUGFIX: Node toolbar position based on actual size #4001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2025
|
I wasn't able to fix this with fully with CSS anchor positioning as I only got it working with latest Chrome and Safari. Firefox didn't like it, and the polyfill (https://github.com/oddbird/css-anchor-positioning) is not easy to apply, as we need to apply it whenever the toolbar is rerendered inside the guest frame. But the polyfill will still be needed for #3972. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Resolved the issue that the toolbar is incorrectly positioned when the assigned element is too small or the toolbar has more items than the default.
Resolves: #2692
How I did it
Via a ResizeObserver the position is updated when the toolbar switches between elements or changes its size due to its content or window limits.
How to verify it
Tested with latest Chrome, Safari, Firefox