Skip to content

Conversation

a-alle
Copy link
Contributor

@a-alle a-alle commented Sep 24, 2025

Description

Currently auth filter and validate update rules are being applied even if properties are not actually being modified but just relationships are being created or deleted.

Complexity

Complexity: Low

Issue

Closes #6620

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@a-alle a-alle requested a review from angrykoala September 24, 2025 15:20
Copy link

changeset-bot bot commented Sep 24, 2025

🦋 Changeset detected

Latest commit: e8e96f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@neo4j/graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Sep 24, 2025

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregateWithMultipleFields 7936 7936 57 80 1134
aggregations.NestedAggregation 15407 15407 71 106 2174
aggregations.AggregationWithWhere 10833 10833 54 73 2174
aggregations.AggregationWhereWithinNestedRelationships 20097917 20097917 1945 2143 2008534
aggregations.AggregationWhereWithinNestedConnections 20097917 20097917 1957 1984 2008534
aggregations.InterfacesAggregations 8324 8324 116 141 2080
aggregations.InterfacesAggregationsWithTwoFields 13526 13526 119 185 2080
connections.Connection 12951 12951 61 78 2174
connections.NestedConnection 37705 37705 142 153 4516
connections.totalCount 1 1 45 42 1
cypher-directive-mutation.TopLevelMutationDirective 1135 1135 50 64 1134
cypher-directive.TopLevelSortWithCypher 12961 12961 41 50 2174
cypher-directive.TopLevelConnectionSortWithCypher 12961 12961 59 85 2174
cypher-directive.TopLevelSortWithCypherWithNested 13096 13096 58 78 2174
cypher-directive.TopLevelConnectionSortWithCypherWithNested 13096 13096 87 123 2174
cypher-directive.TopLevelSortWithExpensiveCypher 13725 13725 99 143 2174
cypher-directive.TopLevelConnectionSortWithExpensiveCypher 13266 13266 97 122 2174
fulltext.Fulltext 80 80 48 55 16
fulltext.FulltextWithNestedQuery 516 516 65 86 84
1262.NestedConnectionWhere 8703 8703 55 85 2174
187.QueryWhere 8564 8564 35 53 2154
2871.NestedRelationshipFilter 19632 19632 58 87 4395
batch-create.BatchCreate 3600 3600 85 106 600
connect.createAndConnect 4410 4410 50 68 1134
create.SimpleMutation 6 6 31 36 1
delete.SimpleDelete 19401 19401 697 642 1040
delete.NestedDeleteInUpdate 14688 14688 111 144 1179
update.NestedUpdate 10129 10129 72 78 2002
query.SimpleQuery 3121 3121 29 28 1040
query.SimpleQueryWithRelationship 15031 15031 60 58 2174
query.SimpleQueryWithNestedWhere 8713 8713 55 79 2154
query.Nested 3988 3988 77 91 1040
query.OrFilterOnRelationships 36730 36496 156 207 1955
query.OrFilterOnRelationshipsAndNested 26719 26531 204 238 1955
query.QueryWithNestedIn 14192 14189 57 76 1864
query.DeeplyNestedConnectionWhere 8702 8702 77 109 2174
query.DeeplyNestedWithRelationshipFilters 17357 17357 133 180 1552
query.NestedWithRelationshipSingleFilters 3808 3808 153 218 1134
sorting.SortMultipleTypes 3436 3436 83 92 1040
sorting.SortMultipleTypesWithCypherWithCypher 13321 13321 97 105 2174
sorting.SortOnNestedFields 12951 12951 49 54 2174
sorting.SortDeeplyNestedFields 39785 39785 87 105 4516
sorting.ConnectionWithSort 3271 3271 68 74 1040
unions.SimpleUnionQuery 321 321 64 61 35
unions.SimpleUnionQueryWithMissingFields 293 293 60 70 35
unions.NestedUnion 309975 309975 261 305 33033
unions.NestedUnionWithMissingFields 283949 283949 258 262 33033

Old Schema Generation: 29.732s
Schema Generation: 28.844s
Old Subgraph Schema Generation: 32.955s
Subgraph Schema Generation: 32.662s

@a-alle a-alle requested a review from angrykoala September 24, 2025 15:39
angrykoala
angrykoala previously approved these changes Sep 24, 2025
Copy link
Contributor

@mjfwebb mjfwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@a-alle a-alle merged commit 858a98f into neo4j:dev Sep 29, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential issue with authorization directive when connecting two nodes
4 participants