test: add failing repro for non-monotone skyline segment boundaries#872
Draft
ivan-aksamentov wants to merge 1 commit into
Draft
test: add failing repro for non-monotone skyline segment boundaries#872ivan-aksamentov wants to merge 1 commit into
ivan-aksamentov wants to merge 1 commit into
Conversation
…boundaries Counterexample for #869: merger_quantile_boundaries clamps duplicate merger-time candidates instead of coalescing them, so requesting more segments than distinct merger times yields zero-width, merger-free segments while the docstring claims every segment owns a merger. The test asserts strictly increasing boundaries and fails on the current head (grid [2000, 2000, 2000, 2002.5, 2005, 2012]). Red test for author consideration; not intended to merge as-is.
Member
|
It is true that some funky things can happen if there are multiple mergers at the same time. This would be circumvented trivially if the intervals were evenly spaced. This would have pros and cons.
cons:
I am a bit on the fence here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red counterexample for #869, base is the PR head branch so CI shows it failing against the code under review. Not intended to merge as-is: the author decides the fix, then adapts or removes the test.
merger_quantile_boundariesclamps each duplicate merger-time candidate against the previous boundary instead of coalescing merger events, so requesting more segments than there are distinct merger times yields zero-width, merger-free segments. That contradicts the docstring claim that every segment owns a merger. Zero-width segments are unreachable throughsegment_index, yet their per-segment log-Tc still participate in the smoothing penalty, so the fitted trajectory depends on phantom transitions.The test requests five segments on a tree with two distinct merger times and asserts strictly increasing boundaries. On the current head it fails with the grid
[2000, 2000, 2000, 2002.5, 2005, 2012]. The existingtest_skyline.rsfixtures already build such over-segmented grids but assert only lengths and finiteness.Work items
SkylineResult.segment_boundariesis strictly increasing for an over-segmented requestPossible improvements
n_points), add tied-merger-time and polytomy cases