fix: make dropped coalescent prior explicit#866
Draft
ivan-aksamentov wants to merge 1 commit into
Draft
Conversation
When constant or skyline coalescent optimization failed with no previous value or --coalescent seed to fall back on, the run proceeded with no coalescent prior while logging the misleading "keeping previous Tc" (there was none to keep). Report the failure explicitly, stating whether the previous prior is retained or the run proceeds with no coalescent prior this round.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix/timetree-coalescent-no-prior-visibility->rustWhen constant or skyline coalescent optimization failed with no previous value and no
--coalescentseed to fall back on, the run proceeded with no coalescent prior while logging the misleading "keeping previous Tc" -- there was no previous value to keep.This reports the failure explicitly, stating whether the previous prior is retained or the run proceeds with no coalescent prior this round [src].
Work items