Skip to content

add passThrough option #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omer72 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add passThrough option #45

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c471ada
add the option to define passThrough
Mar 21, 2016
b6c8b7c
add the option to define passThrough
Mar 21, 2016
94c6c87
add the option to define passThrough
Mar 21, 2016
e196024
add the option to define passThrough
Mar 21, 2016
e0ee516
add the option to define passThrough
Mar 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,17 @@ and can contain a regex:
"uri": "/customer/\\d*/cart"
```

To use the option of bypass the mock and issue real http request, the resource files should look like this:
Copy link
Owner

@nabil-boag nabil-boag Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves its own section i.e.

Bypassing mocks

If you want to bypass mocks and issue a real http request, add an optional passThrough property to your mock.


```json
{
"httpMethod": "GET",
"statusCode": 200,
"uri": "/customer/cart",
"passThrough": true
}
```

### Delayed responses

In some scenarios you may want to simulate a server/network delay.
Expand Down
3 changes: 3 additions & 0 deletions app/src/js/multimocks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ angular
}
return [200, mock.response, mockHeaders];
});
} if (mock.passThrough) {
Copy link
Owner

@nabil-boag nabil-boag Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the if on a new line:

}

if (....

$httpBackend.
when(mock.httpMethod, uriRegExp, mock.requestData).passThrough();
Copy link
Owner

@nabil-boag nabil-boag Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent this line 2 spaces.

} else {
$httpBackend
.when(mock.httpMethod, uriRegExp, mock.requestData)
Expand Down