add passThrough option #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/js/multimocks.js
Outdated
| } | ||
| return [200, mock.response, mockHeaders]; | ||
| }); | ||
| } if (mock.passThrough) { |
Owner
There was a problem hiding this comment.
Please put the if on a new line:
}
if (....
Owner
|
This change is great, but can you please write a test for the new case similar to https://github.com/omer72/angular-multimocks/blob/master/app/src/js/multimocks.spec.js#L132 |
README.md
Outdated
| "uri": "/customer/\\d*/cart" | ||
| ``` | ||
|
|
||
| To use the option of bypass the mock and issue real http request, the resource files should look like this: |
Owner
There was a problem hiding this comment.
I think this deserves its own section i.e.
Bypassing mocks
If you want to bypass mocks and issue a real http request, add an optional passThrough property to your mock.
Contributor
|
Is this something your able to add a test for? would be a nice addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you need to bypass the mock and issue real http request