[Harvester] Auto-send data collection to CRIMS on DC completion#2137
Merged
Conversation
Member
|
Thanks alot for these PRs @jbflo. We will merge the one on It would also be great if as you mentioned before we could migrate this to an adapter, there is no reason for to be a separate component anymore. |
CRIMS upload is now sent automatically when a data collection finishes (see commit 2), making the manual button and its route not needed.
Replaces the manual "Send Data to Crims" button with an automatic trigger: the harvester component now listens to queue_entry_execute_finished and calls send_data_collection_info_to_crims after every successful DataCollectionQueueEntry. The manual route, action, and UI button are removed.
Member
Author
mxcubecore updated |
Member
|
Thanks, very nice. It would be wonderful if you could have a look at that adapter as well ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harvestercomponent connects toqueue_entry_execute_finishedandautomatically POSTs data collection info to CRIMS when a DC completes
successfully
_send_collection_to_crimsextractscrystalUuid,sampleName,instrumentName(beamline_name),facilityName(synchrotron_name),and
investigationID(session_id) from the finished queue entry.Removes the manual "Send Data to Crims" button, its route, Redux
action, and API call — superseded by the automatic trigger.
two required properties:
crims_upload_url(full endpoint URL) andcrims_upload_key.Coupled PR
Requires mxcubecore PR LINK which implements the updated
send_data_collection_info_to_crimsfunction.I might do a followup to convert the component to an adapter next.