[Harvester] Send data collection info to CRIMS after successful DC#1632
Merged
Conversation
| """Send Data collected to CRIMS | ||
| """Send data collection info to CRIMS. | ||
|
|
||
| POST /ispyb_checker/api/v2/informationsforicat |
Member
There was a problem hiding this comment.
I don't think you need this comment
marcus-oscarsson
approved these changes
Jul 8, 2026
marcus-oscarsson
left a comment
marcus-oscarsson
left a comment
Member
There was a problem hiding this comment.
Approved with suggested changes
jbflo
force-pushed
the
jb_crims_dc
branch
2 times, most recently
from
c7cf3ac to
04b67b2
Compare
Rewrites send_data_collection_info_to_crims to match the confirmed CRIMS endpoint: POST /ispyb_checker/api/v2/informationsforicat with a JSON body (crystalUuid, sampleName, instrumentName, facilityName, investigationID) and harvester-key in the header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crims.send_data_collection_info_to_crimsrewritten to match theNew CRIMS endpoint.
Harvester and HarvesterMockup both read crims_upload_url /
crims_upload_key from config (full endpoint URL, no default)
(existing deployments unaffected).
Coupled PR
Requires mxcubeweb PR link which wires the signal handler that calls this
function after a successful data collection.