Conversation
Collaborator
Author
|
not sure why CI run fails. Works on my machine with go 1.23 |
roaree
approved these changes
Jul 22, 2025
| github.com/chzyer/readline v1.5.1 // indirect | ||
| github.com/gookit/color v1.5.4 // indirect | ||
| github.com/klauspost/compress v1.18.0 // indirect | ||
| github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect |
Collaborator
There was a problem hiding this comment.
I think this https://github.com/xo/terminfo dependency is net new from the auto minor-version upgrade of https://github.com/gookit/color , which is ultimately required by our first-level dependency https://github.com/i582/cfmt. I wonder if there isn't a better way to do colored terminal output these days with less dependencies?
These are the only places where we call into the cfmt library as far as I can tell:
Line 84 in facb7a0
Lines 22 to 36 in facb7a0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62