Conversation
roaree
left a comment
roaree
left a comment
There was a problem hiding this comment.
Thanks for the quick PR!
While looking into the question of the original code license from the gist, I found that go v1.22 actually implemented a function for adding an entire directory to a zip archive: https://pkg.go.dev/archive/zip#Writer.AddFS .
I'm not sure if this also suffers from adding backslashes on Windows? It would be good to see if we can just upgrade our go version and replace this code with one line calling that function. Otherwise, for avoidance of any licensing doubt, could you please take the implementing code from Golang directly and modify it accordingly to replace the backslashes? https://cs.opensource.google/go/go/+/refs/tags/go1.24.5:src/archive/zip/writer.go;l=503-542
|
Done. AddFS already handles backslashes |
besendorf
force-pushed
the
fix/windows_zip
branch
from
9251af0 to
2ed5b28
Compare
- Add Go 1.22 setup to both CI and release workflows - Update actions/checkout from v2 to v4 - Update actions/setup-go from v4 to v5 with cache enabled - Update staticcheck version to 2023.1.7 (supports Go 1.22) - Set install-go: false to use our own Go setup - Fix YAML indentation and formatting - Resolves Go 1.22 compilation error
2 participants
fixes #61