Skip to content

Fix so spack can find mpiadvance #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JStewart28 wants to merge 4 commits into from
Closed

Fix so spack can find mpiadvance #37

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5888a1c
Updates so spack can find mpiadvance
JStewart28 Aug 5, 2025
f18c999
Removed version installation
JStewart28 Aug 5, 2025
11c6811
Merge branch 'mpi-advance:master' into spack-package-pull-upstream
JStewart28 Aug 5, 2025
d839686
Update CMakeLists.txt
bienz2 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,11 @@ add_library(mpi_advance
)
target_link_libraries(mpi_advance PUBLIC ${EXTERNAL_LIBS})

install(TARGETS mpi_advance
install(TARGETS mpi_advance
ARCHIVE DESTINATION ${CMAKE_INSTALL_PREFIX}/lib
LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib
RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/bin)
RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
)

install(FILES src/mpi_advance.h DESTINATION ${CMAKE_INSTALL_PREFIX}/include)
install(FILES ${utils_HEADERS} DESTINATION ${CMAKE_INSTALL_PREFIX}/include/utils)
Expand All @@ -123,4 +124,26 @@ endif()

add_subdirectory(benchmarks)

### Installation Requirements for Spack Package ###
include(CMakePackageConfigHelpers)

# Install the actual target(s) and register them for export
install(TARGETS mpi_advance
EXPORT mpiadvanceTargets
DESTINATION lib)

# Export the targets into a CMake package
install(EXPORT mpiadvanceTargets
NAMESPACE mpiadvance::
Copy link
Copy Markdown
Contributor

@TheMasterDirk TheMasterDirk Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do MPIAdvance:: as the namespace?

DESTINATION lib/cmake/mpiadvance)

configure_package_config_file(
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/mpiadvanceConfig.cmake"
"${CMAKE_CURRENT_BINARY_DIR}/mpiadvanceConfig.cmake"
INSTALL_DESTINATION lib/cmake/mpiadvance)
Copy link
Copy Markdown
Contributor

@TheMasterDirk TheMasterDirk Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind making this install to share/mpiadvance?


install(FILES
"${CMAKE_CURRENT_BINARY_DIR}/mpiadvanceConfig.cmake"
DESTINATION lib/cmake/mpiadvance)
Copy link
Copy Markdown
Contributor

@TheMasterDirk TheMasterDirk Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here as the configure_package_config_file

############## End of Spack Section ################

Loading