Fix so spack can find mpiadvance#37
Conversation
Added a comment so we know in the future that this section is needed for space
|
I think this is fine as is. I added a comment so we remember this is needed for spack. |
TheMasterDirk
left a comment
TheMasterDirk
left a comment
There was a problem hiding this comment.
Just wanted to leave some comments on this because Andrew and I are working on making the CMake code organized/consistent between all of the MPI Advance libraries. In the future, we will also likely be renaming this cmake "target" to locality_aware (and thus the various install directories will also need to change to <>/locality_aware), but that big of a change doesn't have to happen in this PR.
| configure_package_config_file( | ||
| "${CMAKE_CURRENT_SOURCE_DIR}/cmake/mpiadvanceConfig.cmake" | ||
| "${CMAKE_CURRENT_BINARY_DIR}/mpiadvanceConfig.cmake" | ||
| INSTALL_DESTINATION lib/cmake/mpiadvance) |
There was a problem hiding this comment.
Would you mind making this install to share/mpiadvance?
|
|
||
| install(FILES | ||
| "${CMAKE_CURRENT_BINARY_DIR}/mpiadvanceConfig.cmake" | ||
| DESTINATION lib/cmake/mpiadvance) |
There was a problem hiding this comment.
Same comment here as the configure_package_config_file
|
|
||
| # Export the targets into a CMake package | ||
| install(EXPORT mpiadvanceTargets | ||
| NAMESPACE mpiadvance:: |
There was a problem hiding this comment.
Can we do MPIAdvance:: as the namespace?
|
Superseded by #41. |
3 participants
Added lines at the end of CMakeLists.txt. The code works, but I am open to changes if there is a more elegant way to incorporate it into the existing CMake.