Skip to content

DRIVERS-3298 Improve stop-orchestration behavior #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 2, 2025
Merged

DRIVERS-3298 Improve stop-orchestration behavior #694

merged 19 commits into from
Oct 2, 2025

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Oct 1, 2025 •
edited
Loading

@blink1073 blink1073 requested a review from eramongodb October 1, 2025 15:45
eramongodb
eramongodb requested changes Oct 1, 2025
View reviewed changes
@blink1073
Copy link
Member Author

blink1073 commented Oct 1, 2025

Thanks for the review! I'll try all the scenarios again locally before asking for another.

eramongodb
eramongodb reviewed Oct 1, 2025
View reviewed changes
.evergreen/orchestration/drivers_orchestration.py Outdated
Comment on lines 641 to 648
try:
proc.terminate()
try:
proc.wait(10) # Wait up to 10 seconds.
except psutil.TimeoutExpired:
proc.kill()
except psutil.NoSuchProcess:
pass
Copy link
Contributor

@eramongodb eramongodb Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, I'll have to remember to avoid this when using GitHub's new PR editor.

@blink1073
Copy link
Member Author

blink1073 commented Oct 1, 2025

Okay, I tested again. I had to escape the quotes in the docker ps command to get it working with shlex.split. I also found that if I started mongo-orchestration start manually in another terminal it had a different cmdline signature, so I added handling for that.

@blink1073 blink1073 requested a review from eramongodb October 1, 2025 17:58
eramongodb
eramongodb approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions/questions remaining; otherwise, LGTM.

@blink1073
Copy link
Member Author

blink1073 commented Oct 1, 2025

I had to account for some platform-specific errors/concerns, it should be good to go now.

@blink1073 blink1073 requested a review from eramongodb October 1, 2025 20:50
eramongodb
eramongodb approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@eramongodb eramongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion; otherwise, LGTM.

@blink1073
Copy link
Member Author

blink1073 commented Oct 2, 2025

The docker failures are unrelated, there was a change in the PPA: "Note: Python 3.10 (jammy), Python3.12 (noble) are not provided by deadsnakes as upstream ubuntu provides those packages."

@blink1073 blink1073 merged commit fe33da2 into mongodb-labs:master Oct 2, 2025
72 of 77 checks passed
@blink1073 blink1073 deleted the improve-stop-behavior branch October 2, 2025 02:18
@blink1073 blink1073 mentioned this pull request Oct 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eramongodb eramongodb eramongodb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blink1073 @eramongodb