always stop mongo orchestration in drivers-orchestarion.py #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Stopping is already part of start, we could remove the conditional there. |
Member
|
The change looks good to me to pick up the case where docker had been used to start the cluster. Was that the issue you were facing? If not, stop relies on a server.pid file being there one way or the other. |
Member
|
Closing in favor of #694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consecutive runs of drivers-orchestation.py fail after the first because mongo-orchestration is already running. This PR updates drivers-orchestration to stop mongo-orchestration, if it is running, before attempting to launch it again.