feat(compass-context-menu): add a headless context menu package COMPASS-9386 #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
May 20, 2025
| export function useContextMenu({ | ||
| Menu, | ||
| }: { | ||
| Menu: React.ComponentType<{ |
There was a problem hiding this comment.
I guess we could keep it headless by letting it accept a component?
Open to a cleaner solution
gagik
force-pushed
the
gagik/headless-context-menu
branch
from
c824499 to
647306f
Compare
gagik
commented
May 21, 2025
| (Content, index) => <Content key={`menu-content-${index}`} /> | ||
| ), | ||
| position: { | ||
| // TODO: Fix handling offset while scrolling |
There was a problem hiding this comment.
Not too sure what this was referring to, just came from the prototype
There was a problem hiding this comment.
I think it's a reminder to check how this functions if the menu is displayed inside a view which is scrolled 🤔
gagik
force-pushed
the
gagik/headless-context-menu
branch
2 times, most recently
from
31f6adf to
43023f4
Compare
gagik
force-pushed
the
gagik/headless-context-menu
branch
from
82a10c5 to
ca1fb86
Compare
…p menu state consistent The refactor is meant to make the Leafygreen integration more straightforward: 1. We stick to item groups and instead have a single wrapper to handle any rendering differences between groups. This allows the wrapper to always have context of all items when rendering which is useful when inserting menu seperators in Leafygreen. Also encourages consistent UI (while allowing per-case customization if needed at wrapper-level). We could introduce itemWrappers instead of itemGroups but having one wrapper handling all seems cleaner to me. 2. More of the responsibility is moved to a parent wrapper component that will house the context menu. This allows us to standardize the right click menu and make better use of Leafygreen's menu component including its click handling (which has been removed from the context menu library). 3. Menu state (i.e. position) is now preserved even closed; this is useful for leafygreen's menu to animate in the same position instead of losing the position all together.
gagik
force-pushed
the
gagik/headless-context-menu
branch
from
ca1fb86 to
ee658e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This acts as the headless basis for #6956 right click component
TODO: