Handlers and Endpoints for Mojaloop/App/Firebase - Linking/Unlinking Flow #24

akapur99 · 2020-08-31T20:29:28Z

Addresses: https://app.zenhub.com/workspaces/mojaloop-project-59edee71d1407922110cf083/issues/mojaloop/project/1654

Implement all endpoint handlers + related domain logic, that deal with Mojaloop
Implement all handlers + related domain logic, that deal with Firebase (the app-side)
Implement consent repository
Unit Tests

Unit Tests for firestore repositories will be handles in a separate PR

src/repositories/consent.ts

src/repositories/participants.ts

src/repositories/transaction.ts

src/server/handlers/firestore/consents.ts

src/server/handlers/firestore/consents.validator.ts

src/server/handlers/openapi/mojaloop/consentRequests/{ID}.ts

src/server/handlers/openapi/mojaloop/consents.ts

src/server/handlers/openapi/mojaloop/consents/{ID}.ts

Making internal methods async

src/repositories/consent.ts

src/repositories/transaction.ts

Change variable naming for clarity

…in repositories

src/server/handlers/openapi/mojaloop/index.ts

src/server/plugins/internal/firestore.ts

kkzeng

lgtm - just a nit and question. Would wait on those who requested changes to approve though before merging

src/server/plugins/internal/firestore.ts

Made changes

src/repositories/participants.ts

Changes made

akapur99 added 24 commits August 25, 2020 10:19

feat: Handler logic for put participants

c6c2dfd

Merge remote-tracking branch 'origin/master' into consentRequest

df32e0f

feat: add outgoing postConsentRequests method in Client

edccad0

feat: create consents Handler

deacbbb

refactor: fix spelling error in getConsentByID

0f17193

feat: Add consentHandlers as default export

4fb2e87

feat: initialize consent handler in firestore

5dbc21c

feat: add method to updateConsentById

ed87a49

feat: add updateConsentById method to interface

fe77c44

feat: Add method to handle creation of consent

667363f

feat: implement handler for PUT consentRequests/{ID}

a35716e

feat: implement postConsent handler

858aec4

fix: status should not be taken from request body

c7f83a2

feat: create ConsentStatus enum and add field to consent object

d51fbe8

feat: allow consent status to be undefined(on creation)

67c8df5

Merge remote-tracking branch 'origin/master' into consentRequest

c4cfd8d

feat: Add update consent method to consent repository

b481c5f

feat: implement handler for PUT parties/{Type}/{ID}

0d389e6

feat: Implement handler for PATCH consents/{ID}

ff99ecb

feat: implement PUT consents/{ID}

6466f1e

feat: add methods to consent Handler

ea4fa3a

feat: Add/update ConsentStatus enum

2cf4491

feat: implement all linking related firestore handlers

8447762

feat: Use ConsentStatus enum instead of hardcoding value

bf7d3c8

akapur99 mentioned this pull request Aug 31, 2020

[pisp-demo-server] Implement Handlers, Repositories, Domain logic Related to Linking/Unlinking Flow mojaloop/project#1654

Closed

11 tasks

akapur99 added 5 commits September 1, 2020 10:53

fix: Correct ConsentStatus Enum used

49812bb

feat: Add/Update handlers in index

a20f0dc

feat: Implement app-side handler for DELETE consents/{ID}

9a49e03

style: updating licence

ba3ed53

feat: add consent validator for firestore handlers

6c28ba5

eoln suggested changes Sep 15, 2020

View reviewed changes

akapur99 added 5 commits September 15, 2020 14:35

feat: Add consent ID to invalidConsentStatusError for clarity

7072fc0

style: Add comments explaining decision to not await async code

e36cdeb

refactor: Change method names to more accurately reflect function

69f4718

refactor: awaiting batch commits in repositories

501af91

Making internal methods async

chore: bump sdk standard components to v 11.8.0

a5a8874

eoln suggested changes Sep 17, 2020

View reviewed changes

src/repositories/consent.ts Outdated Show resolved Hide resolved

src/repositories/transaction.ts Outdated Show resolved Hide resolved

akapur99 added 2 commits September 17, 2020 15:03

fix: Make id a required variable for InvalidConsentStatusError

0e2a6f5

Change variable naming for clarity

refactor: Use try/catch instead of .then/.catch for promise handling …

ca24cbe

…in repositories

akapur99 requested a review from eoln September 17, 2020 10:42

Merge remote-tracking branch 'origin/master' into consentRequest

143777b

This was referenced Sep 18, 2020

Field Type Validation when updating/setting objects in Firebase #32

Open

Error Handling #33

Open

style: remove redundant comment

c52584d

kkzeng reviewed Sep 21, 2020

View reviewed changes

src/server/handlers/openapi/mojaloop/index.ts Show resolved Hide resolved

kkzeng reviewed Sep 21, 2020

View reviewed changes

src/server/plugins/internal/firestore.ts Show resolved Hide resolved

kkzeng approved these changes Sep 21, 2020

View reviewed changes

kkzeng reviewed Sep 21, 2020

View reviewed changes

src/server/plugins/internal/firestore.ts Show resolved Hide resolved

akapur99 added 3 commits September 22, 2020 11:36

build: Bump sdk-standard-components to v11.9.0

06a21b4

feat: Implement getParties request in mojaloopClient

30f7fb7

Merge remote-tracking branch 'origin/master' into consentRequest

a370b25

jgeewax approved these changes Sep 23, 2020

View reviewed changes

style: modified TODO comment

a201c95

eoln previously requested changes Sep 25, 2020

View reviewed changes

src/repositories/participants.ts Outdated Show resolved Hide resolved

fix: removed unneeded comments

38de745

akapur99 requested a review from eoln September 25, 2020 08:47

akapur99 merged commit 9445f54 into master Sep 25, 2020

lewisdaly deleted the consentRequest branch October 14, 2020 03:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handlers and Endpoints for Mojaloop/App/Firebase - Linking/Unlinking Flow #24

Handlers and Endpoints for Mojaloop/App/Firebase - Linking/Unlinking Flow #24

akapur99 commented Aug 31, 2020 •

edited

Loading

kkzeng left a comment

Handlers and Endpoints for Mojaloop/App/Firebase - Linking/Unlinking Flow #24

Handlers and Endpoints for Mojaloop/App/Firebase - Linking/Unlinking Flow #24

Conversation

akapur99 commented Aug 31, 2020 • edited Loading

kkzeng left a comment

Choose a reason for hiding this comment

akapur99 commented Aug 31, 2020 •

edited

Loading