Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field Type Validation when updating/setting objects in Firebase #32

Open
akapur99 opened this issue Sep 18, 2020 · 0 comments
Open

Field Type Validation when updating/setting objects in Firebase #32

akapur99 opened this issue Sep 18, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@akapur99
Copy link
Collaborator

As discussed in this thread: #24 (comment)
We need to be more defensive when adding/updating objects in firebase.
First, we need to add more checks and tests to ensure invalid data is not allowed to be passed into firebase, and if it is, errors should be thrown/logged.

Tasks:

  • Ensure firebase security rules are in place
  • Potentially have an internal validator to validate any objects passed into firebase repository methods
  • Ensure if invalid fields/values are passed in, errors are being logged thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant