Skip to content

docs(publishing): list pack:verify's npm default-bin check - #2659

Merged
cliffhall merged 1 commit into
v2/mainfrom
v2/docs/2658-pack-verify-default-bin
Oct 8, 2026
Merged

cliffhall merged 1 commit into
v2/mainfrom
v2/docs/2658-pack-verify-default-bin

Conversation

@cliffhall

Copy link
Copy Markdown
Member

Closes #2658

docs/publishing.md describes what pack:verify checks. It still said the installed package is driven only through the named mcp-inspector bin, and it omitted the npm exec @modelcontextprotocol/inspector step that #2652 added for #2651. This PR adds that step to the list, with the reason it exists: the package ships two distinct bins, so a bare npx lands only on the inspector alias, and every other check names its bin.

Found by Copilot's review of the v2.10.1 milestone merge (#2657). Per the release skill, the fix goes on v2/main and is re-merged into the merge branch.

This changes docs only. docs/ is outside every gate's format, lint and typecheck scope, so there is no gate stage to re-run.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
@cliffhall cliffhall added the v2 Issues and PRs for v2 label Oct 8, 2026
@cliffhall
cliffhall requested a balanced review from Copilot October 8, 2026 04:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation accurately reflects the implemented packaging verification and linked issue.

0 open findings

What changed in this PR

Updates publishing documentation to match the current pack:verify workflow.

Changes:

  • Documents the npm exec default-bin check and why the inspector alias is required.
File Description
docs/​publishing.md Adds the npm default-bin verification to the publish-smoke inventory.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@cliffhall

Copy link
Copy Markdown
Member Author

Copilot review loop closed: round 1 was clean (0 inline comments, nothing in the headline or a suppressed block).

@cliffhall
cliffhall merged commit 929efa4 into v2/main Oct 8, 2026
5 checks passed
@cliffhall
cliffhall deleted the v2/docs/2658-pack-verify-default-bin branch October 8, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Issues and PRs for v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(publishing): pack:verify inventory omits the npm default-bin check

2 participants