Repository navigation
chore(release): merge v2/main into main for v2.10.1 - #2657
Merged
Merged
Conversation
…inspector` bin alias (#2651) 2.10.0 added `mcpdo` as a second bin. With more than one distinct bin, npm's npx/exec runs only the bin named after the unscoped package name (`inspector`), which didn't exist, so the documented entry point failed with "could not determine executable to run". Add `inspector` -> the launcher, and guard it twice: an offline test:scripts check that the root manifest's npx default bin is the launcher (mirrors libnpmexec's getBinFromManifest), and a pack:verify step that runs the installed tarball via `npm exec` instead of by bin name, which is why every existing check stayed green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
…2651) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
…fault-bin fix(package): restore npx @modelcontextprotocol/inspector with an inspector bin alias
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
…-2-10-1 chore(release): 2.10.1 step 1 — audit, bump to 2.10.1
There was a problem hiding this comment.
🟡 Changes recommended
The canonical publishing guide does not document the newly added release verification step.
1 open finding
What changed in this PR
Merges the v2.10.1 release payload into main, restoring bare npx invocation after adding the mcpdo binary.
Changes:
- Adds the
inspectorlauncher alias and bumps version to 2.10.1. - Adds offline and packaged-tarball verification of npm’s default-bin resolution.
- Documents
mcpdoand the launcher alias.
| File | Description |
|---|---|
README.md |
Documents the fourth client and invocation command. |
clients/launcher/README.md |
Explains the required inspector alias. |
package.json |
Bumps the version and adds the alias. |
package-lock.json |
Records manifest changes. |
scripts/lib/npx-default-bin.mjs |
Mirrors npm’s bin-selection behavior. |
scripts/lib/npx-default-bin.test.mjs |
Tests bin resolution and the root manifest. |
scripts/pack-and-verify.mjs |
Exercises default-bin selection from the installed tarball. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
…verify-default-bin docs(publishing): list pack:verify's npm default-bin check
Member
Author
There was a problem hiding this comment.
🟢 Approval recommended
The release payload is consistent, adequately tested, and the prior documentation gap is resolved.
0 open findings
1 resolved since last review
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #2654
Milestone merge of
v2/mainintomainfor the v2.10.1 patch release, which is step 2 of thereleaseskill. 2.10.1 fixes #2651: on 2.10.0,npx @modelcontextprotocol/inspectorfails with "could not determine executable to run".This is a pure merge
The merged tree is byte-identical to
origin/v2/mainand reads 2.10.1, bumped onv2/mainin #2653 / PR #2655. The payload since 2.10.0 is PR #2652 (theinspectorbin alias, its two guards, and the README's mcpdo entry) plus the bump.Verification
Ledger: https://claude.ai/artifact/NKoqS9ANaGb6Yx5ANPdcdU (for maintainer review; one row per closed milestone issue, with what was run and what was observed)
npm run local:gateon this tree passes every stage exceptsmoke:web:firefox. That stage cannot launch Playwright's Firefox on macOS 27 (smoke:web:firefox cannot launch Playwright's Firefox on macOS 27 #2625). The three Firefox smokes were run from a clean export of this exact tree in the Linux Playwright container, and all passed. Storybook (529) was run separately, since the Firefox failure stops the gate chain before that stage.npm run pack:verify: OK (27 files, 5.70 MB unpacked), including its newnpm exec @modelcontextprotocol/inspectorstep.npm audit: 0 vulnerabilities in all six installs.npxof the published 2.10.0 fails.npx -y file:<tgz>andnpm exec @modelcontextprotocol/inspectorboth run the launcher.2.10.1.Found by review, fixed on
v2/maindocs/publishing.mddid not list the newpack:verifydefault-bin step (Copilot, round 1). The fix is one line indocs/publishing.md, which no gate stage or smoke reads, so the gate,pack:verifyand smoke results above stand for the final tree.🤖 Generated with Claude Code