Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Challenge 16: Iterator #260

Merged
merged 23 commits into from
Apr 4, 2025

Conversation

thanhnguyen-aws
Copy link

@thanhnguyen-aws thanhnguyen-aws commented Feb 28, 2025

In this PR, I add a challenge for Iterator functions in (library/core/src/iter/adapters)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@thanhnguyen-aws thanhnguyen-aws requested a review from a team as a code owner February 28, 2025 16:15
Copy link

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why some of these challenges are focused on correctness.

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You'll need to add links to these challenge files in SUMMARY.md as well.
  2. I don't think we should merge any challenges about correctness--this effort is about safety, and we should stay focused on that goal.

@thanhnguyen-aws thanhnguyen-aws changed the title Add 10 more challenges Add Challenge 16: Iterator Mar 6, 2025
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See my comment above about reward amounts; we still shouldn't merge this yet, but on the technical side we're good to go.

@carolynzech carolynzech enabled auto-merge April 2, 2025 19:49
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger approval check

@carolynzech carolynzech added this pull request to the merge queue Apr 4, 2025
Merged via the queue into model-checking:main with commit 9da1baa Apr 4, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants