qemu: Enable the SDL UI frontend by default on OS X < 10.5. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QEMU normally enables the Cocoa UI frontend by default when building for OS X, but this is unusable on < 10.5 due to missing features on these OS X versions. This change allows users building QEMU for 10.4.x to have a UI by default (like what you would get building it for >= 10.5), instead of having to remember to specify the --with-sdl build flag. Otherwise, OS X 10.4.x users who run `brew install qemu` without this commit will end up building headless/VNC-only binaries of QEMU, which they may not expect.
akemin-dayo
force-pushed
the
qemu-tiger-sdl-by-default
branch
from
5a7afb2 to
3cff528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QEMU normally enables the Cocoa UI frontend by default when building for OS X, but this is unusable on < 10.5 due to missing features on these OS X versions.
This change allows users building QEMU for 10.4.x to have a UI by default (like what you would get building it for >= 10.5), instead of having to remember to specify the
--with-sdlbuild flag.Otherwise, OS X 10.4.x users who run
brew install qemuwithout this commit will end up building headless/VNC-only binaries of QEMU, which they may not expect.brew install qemu→ PASS (OS X 10.5.8 [--cc=gcc-7is required, a future PR will address this] and OS X 10.4.11, both PowerPC)brew audit qemu→ PASSbrew test qemu→ PASS (PR #769 required)