Skip to content

Commit

Permalink
qemu: Enable the SDL UI frontend by default on OS X < 10.5.
Browse files Browse the repository at this point in the history
QEMU normally enables the Cocoa UI frontend by default when building for OS X, but this is unusable on < 10.5 due to missing features on these OS X versions.

This change allows users building QEMU for 10.4.x to have a UI by default (like what you would get building it for >= 10.5), instead of having to remember to specify the --with-sdl build flag.

Otherwise, OS X 10.4.x users who run `brew install qemu` without this commit will end up building headless/VNC-only binaries of QEMU, which they may not expect.
  • Loading branch information
akemin-dayo committed Oct 14, 2021
1 parent 69f723b commit 3cff528
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions Library/Formula/qemu.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ class Qemu < Formula
depends_on "glib"
depends_on "pixman"
depends_on "vde" => :optional
depends_on "sdl" => :optional
if MacOS.version < :leopard
# Enable the SDL UI by default on OS X versions older than 10.5 because the Cocoa UI (which is otherwise enabled by default) is unavailable on these OS X versions.
depends_on "sdl" => :recommended
else
depends_on "sdl" => :optional
end
depends_on "gtk+" => :optional
depends_on "libssh2" => :optional

Expand Down Expand Up @@ -46,7 +51,7 @@ def install
--disable-guest-agent
]

# Cocoa UI uses features that require 10.5 or newer
# The Cocoa UI uses features that require OS X 10.5 or newer, so we only enable it by default on those OS X versions.
if MacOS.version > :tiger
args << "--enable-cocoa"
else
Expand Down

0 comments on commit 3cff528

Please sign in to comment.