-
Notifications
You must be signed in to change notification settings - Fork 33
Miking Meeting Notes 2025
Note-taker: Viktor Palmkvist
Participants: Gizem Çaylak, David Broman, Lars Hummelgren, Tim Virgoulay, John Wikman, William Muth, Oscar Eriksson
Pull Request
- Gizem: https://github.com/miking-lang/miking-dppl/pull/196
- We like
- William: https://github.com/miking-lang/miking/pull/934
- We like
- William: https://github.com/miking-lang/miking-lang.github.io/pull/35
- Remove instead of comment out, then we like
- William: https://github.com/miking-lang/miking-lang.github.io/pull/34
- Update node version in github action, then we like
- William: https://github.com/miking-lang/miking/pull/935
- Make interactive the default, have
make test-all
run in non-interactive mode, then we like
- Make interactive the default, have
- Viktor: https://github.com/miking-lang/miking/pull/936
- We like
From last meeting, but wasn't in the meeting notes
- Viktor: https://github.com/miking-lang/miking/pull/932
- We like
Discussion:
When the test suite has a test case that is expected to fail and does indeed fail it prints "FAIL", which can be interpreted as " the test failed, which is a thing we don't want". William will make an issue.
Note-taker: John Wikman
Participants: Gizem Çaylak, Viktor Palmkvist, William Muth, Oscar Eriksson, Lars Hummelgren, John Wikman, Anders Ågren Thuné, David Broman
Pull Request
- Oscar:
-
https://github.com/miking-lang/miking-dppl/pull/195
- We like, merge
-
https://github.com/miking-lang/miking-dppl/pull/195
- William:
-
https://github.com/miking-lang/miking/pull/925
- We like, merge
-
https://github.com/miking-lang/miking/pull/926
- We like, but need an extra PR afterwards to fix the git ignore commit.
- Also the lint should be added to the make test.
- Ping David when these are done.
-
https://github.com/miking-lang/miking-lang.github.io/pull/33
- We like, merge
-
https://github.com/miking-lang/miking/pull/925
- Viktor:
-
https://github.com/miking-lang/miking/pull/928
- We like, merge
-
https://github.com/miking-lang/miking/pull/931
- We like, merge
-
https://github.com/miking-lang/miking/pull/930
- We like, merge
-
https://github.com/miking-lang/miking/pull/928
- John:
-
https://github.com/miking-lang/miking/pull/929
- We like, merge
- Need to update the documentation to not refer to ipopt anymore.
-
https://github.com/miking-lang/miking/pull/933
- We like the updates to bool.mc and sys.mc, but split the update to test-spec.mc into a separate PR.
- Ping David once this is done, then merge.
-
https://github.com/miking-lang/miking/pull/929
Note-taker: Lars Hummelgren
Participants: Lars Hummelgren, Tim Virgoulay, David Broman, John Wikman, Viktor Palmkvist, Oscar Eriksson, Gizem Çaylak
Pull Request
- Viktor:
- ProbTime: https://github.com/miking-lang/ProbTime/pull/4
- We decided not to merge this but keep it as a draft
- Merge the following two PRs together:
- ProbTime: https://github.com/miking-lang/ProbTime/pull/4
- Oscar:
-
https://github.com/miking-lang/miking/pull/919
- We like, merge
-
https://github.com/miking-lang/miking/pull/920
- We like, merge
-
https://github.com/miking-lang/miking/pull/919
- Viktor:
- https://github.com/miking-lang/miking/pull/921
-
https://github.com/miking-lang/miking-dppl/pull/194
- We like, merge the above two together
-
https://github.com/miking-lang/miking/pull/922
- We like, merge
-
https://github.com/miking-lang/miking/pull/923
- We like, merge
Note-taker: Oscar Eriksson
Participants: Lars Hummelgren, Gizem Çaylak, Viktor Palmkvist, John Wikman, Oscar Eriksson, Tim Virgoulay, Erik Danielsson, David Broman.
Pull Request
- Viktor, should be merged from top to bottom.
-
https://github.com/miking-lang/miking/pull/911
- We like, merge.
-
https://github.com/miking-lang/miking/pull/912
- We like, merge.
-
https://github.com/miking-lang/miking/pull/914
- We like, merge.
-
https://github.com/miking-lang/miking/pull/915
- We like, merge.
-
https://github.com/miking-lang/miking/pull/916
- We like, merge.
-
https://github.com/miking-lang/miking/pull/917
- We like, merge.
-
https://github.com/miking-lang/miking/pull/918
- We like, merge.
-
https://github.com/miking-lang/miking/pull/913
- Add test, then we like merge.
-
https://github.com/miking-lang/miking-dppl/pull/192
- We like, merge. It should be merged with 898.
-
https://github.com/miking-lang/miking/pull/911
Note-taker: Gizem Caylak
Participants: Lars Hummelgren, Gizem Çaylak, Viktor Palmkvist, John Wikman, Oscar Eriksson, Didrik Munther
Pull Requests
- William: https://github.com/miking-lang/miking-dppl/pull/193
- We like, merge.
- Erik: https://github.com/miking-lang/miking/pull/907
- We like, merge.
- Oscar: https://github.com/miking-lang/miking/pull/908
- We like, merge
- Viktor P.: https://github.com/miking-lang/miking/pull/909
- We like, merge
- Didrik : https://github.com/miking-lang/miking/pull/906
- We like but need to fix the issues discussed in the meeting. Ping David.
Note-taker: Viktor Palmkvist
Participants: Tim Virgoulay, Lars Hummelgren, David Broman, Gizem Çaylak, Viktor Palmkvist, John Wikman, Oscar Eriksson, Didrik Munther, William Muth
Pull Requests
- William: https://github.com/miking-lang/miking/pull/905
- We like. Also change the same file in miking-lang/miking-dppl.
- Marten: https://github.com/miking-lang/miking/pull/882
- Now updated for the new build system, we like.
- Didrik: https://github.com/miking-lang/miking/pull/906
- Make readBytesBuffered tail-recursive, then we like. (DONE)
Discussion
New script for testing multiple repositories at once seems promising, make it output the PR-groups to the log, then experiment with automatically committing and pushing to a repository when the run has completed.
Note-taker: Oscar Eriksson
Participants: Tim Virgoulay, Lars Hummelgren, Viktor Palmkvist, John Wikman, Oscar Eriksson, David Broman, Gizem Çaylak
Pull Requests
- Gizem:
-
https://github.com/miking-lang/miking/pull/903
- We like, merge.
-
https://github.com/miking-lang/miking/pull/903
Old PRs left to merge
- Miking: 876
- Miking-DPPL: 189
Discussion
We discussed microbenchmarks for external arrays. We should switch from Tensor to external array-based vectors and matrices, although this does not solve all performance problems. We need to look into how we generate OCaml code to be on par with OCaml. We will start by implementing a Bigarrays-based matrix library and move to using that library instead of tensors in coreppl/treeppl. We should also remove tensors from the documentation.
Note-taker: John Wikman
Participants: Tim Virgoulay, Lars Hummelgren, Viktor Palmkvist, John Wikman, Oscar Eriksson, Anders Ågren Thuné, David Broman
Pull Requests
- Viktor:
-
https://github.com/miking-lang/miking/pull/897
- We like
-
https://github.com/miking-lang/miking/pull/898
- We like
-
https://github.com/miking-lang/miking/pull/899
- We like
-
https://github.com/miking-lang/miking/pull/900
- Add a named variable for the magic constant 4. Then we like.
-
https://github.com/miking-lang/miking/pull/902
- We like, but there is a discussion to be had how we should treat Ref and Symbol compared to Int, Float, etc. Should we have a TySymbol AST node or should all be created as TyCon? Add it as a separate issue.
-
https://github.com/miking-lang/miking/pull/901
- (Includes all the PRs above)
- Now there is a generate-utest.mc, in addition to utest-generate.mc. Should aim to remove utest-generate.mc in the future when we can.
- On a separate note, would also be good to have a test that checks that utest are actually running.
- Viktor need to remove some debugging things, then we like.
-
https://github.com/miking-lang/miking-dppl/pull/192
- We discussed this PR, but there are still things to be done. Will present again at a later date when it is ready.
-
https://github.com/miking-lang/miking/pull/897
Note-taker: Viktor Palmkvist
Participants: Lars Hummelgren, Oscar Eriksson, Viktor Palmkvist, Tim Virgoulay, John Wikman, Gizem Çaylak, David Broman, Anders Ågren Thuné
Pull Requests
- Tim: https://github.com/miking-lang/miking-dppl/pull/191
- Implement fallback to prior distributino if no explicit drift-kernel is supported. Add a test that is fast and included in normal test suite, but is much less precise. Also fix Oscar's comment. Then we like.
- Oscar: https://github.com/miking-lang/miking/pull/896
- We like
Discussions Proposal: remove tensors as a built-in part of the language. Refactor or remove dependent code, primarily shifting to use externals that implement vectors and matrixes directly. Oscar can write that library.
Note-taker: Lars Hummelgren
Participants: Lars Hummelgren, Oscar Eriksson, Viktor Palmkvist, Anders Ågren Thuné, Tim Virgoulay, John Wikman, Gizem Çaylak
Pull Requests
- Viktor
-
https://github.com/miking-lang/miking/pull/889
- Wait until we know how it conflicts with PR 882
-
https://github.com/miking-lang/miking/pull/891
- Add at least one test for
avlIntersectWithKey
, then we like
- Add at least one test for
-
https://github.com/miking-lang/miking/pull/894
- Looks good, but we would like to know about the performance diff
- https://github.com/miking-lang/miking/pull/888
- https://github.com/miking-lang/miking/pull/890
- https://github.com/miking-lang/miking/pull/892
- https://github.com/miking-lang/miking/pull/893
-
https://github.com/miking-lang/miking/pull/895
- We like, merge
-
https://github.com/miking-lang/miking/pull/889
Discussions
- https://github.com/miking-lang/miking/pull/876 and the corresponding one in DPPL https://github.com/miking-lang/miking-dppl/pull/189 are ready to be merged (they were presented in November, though the DPPL one is not in the notes).