Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Endpoint for Custom Services #628

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kur4mot0
Copy link

@kur4mot0 kur4mot0 commented Aug 9, 2022

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@ghost
Copy link

ghost commented Aug 9, 2022

CLA assistant check
All CLA requirements met.

@xuzhang3
Copy link
Collaborator

@kur4mot0 unit test fail

--- FAIL: TestProvider_HasChildResources (0.00s)
    provider_test.go:77: 
        	Error Trace:	provider_test.go:77
        	Error:      	Not equal: 
        	            	expected: 62
        	            	actual  : 63
        	Test:       	TestProvider_HasChildResources
        	Messages:   	There are an unexpected number of registered resources
FAIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants