Custom service endpoint support #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added custom data attribute to allow more attributes to be passed Added the plugin to the provider unit tests
|
@microsoft-github-policy-service agree |
xuzhang3
requested changes
Jan 3, 2023
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_custom.go
Show resolved
Hide resolved
| Type: schema.TypeMap, | ||
| Description: "Optional payload required for the creation of the endpoint", | ||
| } | ||
| secretHashKey, secretHashSchema := tfhelper.GenerateSecreteMemoSchema("password") |
There was a problem hiding this comment.
Hash keys can be deleted. This functions has be deprecated.
function has been deprecated
|
@Bug-Solver Can you add some test case for this resource? The document should be documented in azuredevops.erb |
xuzhang3
requested changes
Feb 17, 2023
| Description: "The password or token key to use for the Custom service connection.", | ||
| Sensitive: true, | ||
| Optional: true, | ||
| DiffSuppressFunc: tfhelper.DiffFuncSuppressSecretChanged, |
There was a problem hiding this comment.
recommend remove the DiffSuppressFunc as this functions used to handle the hash encoded data which has ben deprecated and no hash key defined for password in this schema.
| d.Set("server_url", *serviceEndpoint.Url) | ||
| d.Set("username", (*serviceEndpoint.Authorization.Parameters)["username"]) | ||
| d.Set("data", *serviceEndpoint.Data) | ||
| tfhelper.HelpFlattenSecret(d, "password") |
There was a problem hiding this comment.
tfhelper.HelpFlattenSecret(d, "password") can be delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
What about the current behavior has changed?
Added behavior to allow the creation of "custom" service endpoints. It is possible to write custom extensions for Azure DevOps. However, the creation cannot be automated through Terraform as ever type of service connection has been hard coded.
This PR is a copy of #628 which appears to have gone stale after the initial PR.
That later version has been expanded upon and the failing unit test have been enhanced to include the new functionality
Issue Number:
Does this introduce a change to
go.mod,go.sumorvendor/?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information